content/renderer/push_messaging_dispatcher.cc - Issue 770023002: Push registration should read a "gcm_user_visible_only" key from the Manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/push_messaging_dispatcher.cc

Issue 770023002: Push registration should read a "gcm_user_visible_only" key from the Manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/push_messaging_dispatcher.cc

diff --git a/content/renderer/push_messaging_dispatcher.cc b/content/renderer/push_messaging_dispatcher.cc

index 763a8e944146970950a3f34ebbed4a1f53adb0f1..f9888a74922a7abc43e211db8269243de6d0f7ba 100644

--- a/content/renderer/push_messaging_dispatcher.cc

+++ b/content/renderer/push_messaging_dispatcher.cc

@@ -14,7 +14,6 @@

#include "third_party/WebKit/public/platform/WebPushRegistration.h"

#include "third_party/WebKit/public/platform/WebServiceWorkerProvider.h"

#include "third_party/WebKit/public/platform/WebString.h"

-#include "third_party/WebKit/public/web/WebUserGestureIndicator.h"

#include "url/gurl.h"

using blink::WebString;

@@ -76,7 +75,7 @@ void PushMessagingDispatcher::DoRegister(

manifest.gcm_sender_id.is_null()

? std::string()

: base::UTF16ToUTF8(manifest.gcm_sender_id.string()),

- blink::WebUserGestureIndicator::isProcessingUserGesture(),

+ manifest.gcm_user_visible_only,

service_worker_provider_id));

}

« no previous file with comments | « content/renderer/manifest/manifest_parser_unittest.cc ('k') | no next file » | no next file with comments »