content/public/common/manifest.cc - Issue 770023002: Push registration should read a "gcm_user_visible_only" key from the Manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/manifest.cc

Issue 770023002: Push registration should read a "gcm_user_visible_only" key from the Manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/common/manifest.cc

diff --git a/content/public/common/manifest.cc b/content/public/common/manifest.cc

index 292b85b44dbad8fce4c7c3453279d7af6bf723f3..389754189cecbc5713782cd182839a1e5a2bc8bf 100644

--- a/content/public/common/manifest.cc

+++ b/content/public/common/manifest.cc

@@ -18,7 +18,8 @@ Manifest::Icon::~Icon() {

Manifest::Manifest()

: display(DISPLAY_MODE_UNSPECIFIED),

- orientation(blink::WebScreenOrientationLockDefault) {

+ orientation(blink::WebScreenOrientationLockDefault),

+ gcm_user_visible_only(false) {

}

Manifest::~Manifest() {

@@ -31,7 +32,8 @@ bool Manifest::IsEmpty() const {

display == DISPLAY_MODE_UNSPECIFIED &&

orientation == blink::WebScreenOrientationLockDefault &&

icons.empty() &&

- gcm_sender_id.is_null();

+ gcm_sender_id.is_null() &&

+ !gcm_user_visible_only;

}

} // namespace content

« no previous file with comments | « content/public/common/manifest.h ('k') | content/renderer/manifest/manifest_parser.h » ('j') | no next file with comments »