Push registration should read a "gcm_user_visible_only" key from the Manifest.

chrome/browser/services/gcm/push_messaging_service_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/services/gcm/push_messaging_service_impl.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 211 matching lines @@
 GURL PushMessagingServiceImpl::PushEndpoint() {
   return GURL(std::string(kPushMessagingEndpoint));
 }
 
 void PushMessagingServiceImpl::RegisterFromDocument(
     const GURL& requesting_origin,
     int64 service_worker_registration_id,
     const std::string& sender_id,
     int renderer_id,
     int render_frame_id,
-    bool user_gesture,
+    bool user_visible_only,
     const content::PushMessagingService::RegisterCallback& callback) {
   if (!gcm_profile_service_->driver()) {
     NOTREACHED() << "There is no GCMDriver. Has GCMProfileService shut down?";
     return;
   }
 
   PushMessagingApplicationId application_id = PushMessagingApplicationId(
       requesting_origin, service_worker_registration_id);
   DCHECK(application_id.IsValid());
 
@@ skipping 32 matching lines @@
   gcm::PushMessagingPermissionContext* permission_context =
       gcm::PushMessagingPermissionContextFactory::GetForProfile(profile_);
 
   if (permission_context == NULL) {
     RegisterEnd(callback,
                 std::string(),
                 content::PUSH_REGISTRATION_STATUS_PERMISSION_DENIED);
     return;
   }
 
+  // TODO(miguelg): Consider the value of |user_visible_only| when making
+  // the permission request.
+  // TODO(mlamouri): Move requesting Push permission over to using Mojo, and
+  // re-introduce the ability of |user_gesture| when bubbles require this.

[mlamouri (slow - plz ping), 2014/12/03 15:29:01]

Could you point to the bug. plz.

[Peter Beverloo, 2014/12/03 15:41:10]

Pointed to 423770.

   permission_context->RequestPermission(
-      web_contents, id, embedding_origin, user_gesture,
+      web_contents, id, embedding_origin, true /* user_gesture */,

[johnme, 2014/12/03 15:36:31]

It's not clear from https://crbug.com/423770 what the current status of
user_gesture is. Is the renderer now doing the checks like "on the renderer
side, any permission request after page load that isn't coming with a user
gesture will fail;" that are mentioned in that bug?

[Peter Beverloo, 2014/12/03 15:41:10]

Negative. Push is the feature using IPC-based permission requests, and I'm
hoping we'll be able to convert it to use Mojo before we ship (in fact, I'm
inclined to do it myself if Mounir doesn't beat me to it). This is an open issue
for all the Mojo code-paths, which will collectively be addressed there.

       base::Bind(&PushMessagingServiceImpl::DidRequestPermission,
                  weak_factory_.GetWeakPtr(), application_id, sender_id,
                  callback));
 }
 
 void PushMessagingServiceImpl::RegisterFromWorker(
     const GURL& requesting_origin,
     int64 service_worker_registration_id,
     const std::string& sender_id,
     const content::PushMessagingService::RegisterCallback& register_callback) {
@@ skipping 140 matching lines @@
 }
 
 void PushMessagingServiceImpl::AddAppHandlerIfNecessary() {
   if (gcm_profile_service_->driver()->GetAppHandler(
           kPushMessagingApplicationIdPrefix) != this)
     gcm_profile_service_->driver()->AddAppHandler(
         kPushMessagingApplicationIdPrefix, this);
 }
 
 }  // namespace gcm