Push registration should read a "gcm_user_visible_only" key from the Manifest.

chrome/browser/services/gcm/push_messaging_service_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SERVICES_GCM_PUSH_MESSAGING_SERVICE_IMPL_H_
 #define CHROME_BROWSER_SERVICES_GCM_PUSH_MESSAGING_SERVICE_IMPL_H_
 
 #include "base/compiler_specific.h"
 #include "base/memory/weak_ptr.h"
 #include "components/gcm_driver/gcm_app_handler.h"
@@ skipping 36 matching lines @@
       const GCMClient::SendErrorDetails& send_error_details) override;
   void OnSendAcknowledged(const std::string& app_id,
                           const std::string& message_id) override;
   bool CanHandle(const std::string& app_id) const override;
 
   // content::PushMessagingService implementation:
   void Register(
       const GURL& origin,
       int64 service_worker_registration_id,
       const std::string& sender_id,
+      bool user_visible_only,
       int renderer_id,
       int render_frame_id,
       bool user_gesture,
       const content::PushMessagingService::RegisterCallback& callback) override;
   blink::WebPushPermissionStatus GetPermissionStatus(

[Miguel Garcia, 2014/12/03 14:02:51]

I think we need user_visible_only here as well so we can properly answer the
question. This might need to fed from storage (not just from the manifest) for
the case where the method is used within a service worker.

[Peter Beverloo, 2014/12/03 15:01:59]

Added a TODO in PushMessagingMessageFilter::OnRegisterFromDocument.

       const GURL& requesting_origin,
       int renderer_id,
       int render_frame_id) override;
 
   void SetProfileForTesting(Profile* profile);
 
  private:
   void IncreasePushRegistrationCount(int add);
   void DecreasePushRegistrationCount(int subtract);
 
@@ skipping 24 matching lines @@
   int push_registration_count_;
 
   base::WeakPtrFactory<PushMessagingServiceImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PushMessagingServiceImpl);
 };
 
 }  // namespace gcm
 
 #endif  // CHROME_BROWSER_SERVICES_GCM_PUSH_MESSAGING_SERVICE_IMPL_H_