Issue 769943003: ui: Fix all 'gn check' errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 769943003: ui: Fix all 'gn check' errors. (Closed)

Created:
6 years ago by tfarina

Modified:
6 years ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, brettw, Dirk Pranke, jamesr, scottmg

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

ui: Fix all 'gn check' errors. This was checked with the following command line: $ out/Debug/gn check out_gn/Debug //ui/* And cleaned until it reported "Header dependency check OK". BUG=367595, 376000 TEST=see above R=sky@chromium.org Committed: https://crrev.com/905f3d99a61d2d77e624f6bf06458085d7e3ee6f Cr-Commit-Position: refs/heads/master@{#307043}

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -2 lines)			Patch
M	ui/aura/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/base/BUILD.gn	View	2 chunks	+1 line, -1 line	0 comments	Download
M	ui/base/ui_base.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/compositor/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/769943003/1

6 years ago (2014-12-05 17:12:08 UTC) #4

commit-bot: I haz the power

6 years ago (2014-12-05 18:00:32 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/905f3d99a61d2d77e624f6bf06458085d7e3ee6f
Cr-Commit-Position: refs/heads/master@{#307043}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages