Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: components/cronet/android/histogram_manager.cc

Issue 769873003: Add UMA Histogram Manager to Cronet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Build Raman's CL. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/histogram_manager.cc
diff --git a/components/cronet/android/histogram_manager.cc b/components/cronet/android/histogram_manager.cc
new file mode 100644
index 0000000000000000000000000000000000000000..c0fce1106489e981a9247fc87968f0573b652772
--- /dev/null
+++ b/components/cronet/android/histogram_manager.cc
@@ -0,0 +1,82 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/cronet/android/histogram_manager.h"
+
+#include <string>
+
+#include "base/android/jni_array.h"
+#include "base/memory/singleton.h"
+#include "base/metrics/histogram.h"
+#include "base/metrics/histogram_samples.h"
+#include "components/metrics/histogram_encoder.h"
+
+#include "jni/HistogramManager_jni.h"
+
+namespace cronet {
+
+// Explicitly register static JNI functions.
+bool HistogramManagerRegisterJni(JNIEnv* env) {
+ return RegisterNativesImpl(env);
+}
+
+HistogramManager::HistogramManager() : histogram_snapshot_manager_(this) {
+}
+
+HistogramManager::~HistogramManager() {
+}
+
+// static
+HistogramManager* HistogramManager::GetInstance() {
+ return Singleton<HistogramManager>::get();
+}
+
+void HistogramManager::RecordDelta(const base::HistogramBase& histogram,
+ const base::HistogramSamples& snapshot) {
+ std::string histogram_name("cronet");
+ metrics::RecordHistogramDelta(histogram_name, snapshot, &uma_proto_);
+}
+
+void HistogramManager::InconsistencyDetected(
+ base::HistogramBase::Inconsistency problem) {
+ UMA_HISTOGRAM_ENUMERATION("Histogram.InconsistenciesBrowser.Cronet",
+ problem, base::HistogramBase::NEVER_EXCEEDED_VALUE);
+}
+
+void HistogramManager::UniqueInconsistencyDetected(
+ base::HistogramBase::Inconsistency problem) {
+ UMA_HISTOGRAM_ENUMERATION("Histogram.InconsistenciesBrowserUnique.Cronet",
+ problem, base::HistogramBase::NEVER_EXCEEDED_VALUE);
+}
+
+void HistogramManager::InconsistencyDetectedInLoggedCount(int amount) {
+ UMA_HISTOGRAM_COUNTS("Histogram.InconsistentSnapshotBrowser.Cronet",
+ std::abs(amount));
+}
+
+std::vector<uint8> HistogramManager::GetDeltas() {
+ // Clear the protobuf between calls.
+ uma_proto_.Clear();
+ histogram_snapshot_manager_.PrepareDeltas(
+ base::Histogram::kNoFlags, base::Histogram::kUmaTargetedHistogramFlag);
+ int data_size = uma_proto_.ByteSize();
+ std::vector<uint8> data(data_size);
+ if (!uma_proto_.SerializeToArray(&data[0], data_size)) {
+ data.clear();
+ }
+
+ return data;
+}
+
+static jbyteArray GetHistogramDeltas(JNIEnv* env, jobject jcaller) {
+ // TODO(mef): convert histogram_manager singleton to hang off java object.
+ std::vector<uint8> data = HistogramManager::GetInstance()->GetDeltas();
+ if (!data.empty()) {
+ return base::android::ToJavaByteArray(env, &data[0], data.size()).Release();
+ }
+
+ return NULL;
+}
+
+} // namespace cronet

Powered by Google App Engine
This is Rietveld 408576698