Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 769783002: Modifying aria-level AX test due to changes related to aria-level for heading. (Closed)

Created:
6 years ago by shreeramk
Modified:
6 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Modifying aria-level AX test due to changes related to aria-level for heading. This CL depends on https://codereview.chromium.org/762103002/ and https://codereview.chromium.org/775533002/ BUG=365082 Committed: https://crrev.com/1c8a3538dc005a66abbc5552e288faae4c8b6ebd Cr-Commit-Position: refs/heads/master@{#307290}

Patch Set 1 #

Patch Set 2 : updating expectations for mac #

Patch Set 3 : updating aria-level #

Patch Set 4 : skipping test on android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -14 lines) Patch
M content/test/data/accessibility/aria-level.html View 1 2 1 chunk +9 lines, -6 lines 0 comments Download
M content/test/data/accessibility/aria-level-expected-android.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/aria-level-expected-mac.txt View 1 2 1 chunk +14 lines, -4 lines 0 comments Download
M content/test/data/accessibility/aria-level-expected-win.txt View 1 2 1 chunk +14 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
shreeramk
Please review. There is one thing which is weird. I have modified aria-level.html i.e. added ...
6 years ago (2014-12-01 08:47:00 UTC) #2
shreeramk
On 2014/12/01 08:47:00, shreeramk wrote: > Please review. > > There is one thing which ...
6 years ago (2014-12-08 17:12:45 UTC) #3
dmazzoni
I added android_fyi_dbg_tests_recipe, maybe that will run. I think you should add the SKIP line ...
6 years ago (2014-12-08 17:19:47 UTC) #4
dmazzoni
lgtm ok to land after taking care of android
6 years ago (2014-12-08 17:20:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/769783002/60001
6 years ago (2014-12-08 17:44:00 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-08 18:45:04 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-08 18:46:03 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1c8a3538dc005a66abbc5552e288faae4c8b6ebd
Cr-Commit-Position: refs/heads/master@{#307290}

Powered by Google App Engine
This is Rietveld 408576698