Move AW renderer compositor context to gpu thread

content/browser/android/in_process/synchronous_compositor_factory_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/in_process/synchronous_compositor_factory_impl.h"
 
+#include "base/command_line.h"
 #include "base/observer_list.h"
 #include "content/browser/android/in_process/synchronous_compositor_external_begin_frame_source.h"
 #include "content/browser/android/in_process/synchronous_compositor_impl.h"
 #include "content/browser/android/in_process/synchronous_compositor_output_surface.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/renderer/gpu/frame_swap_message_queue.h"
 #include "gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.h"
 #include "gpu/command_buffer/client/gl_in_process_context.h"
 #include "gpu/command_buffer/common/gles2_cmd_utils.h"
+#include "gpu/command_buffer/service/gpu_switches.h"
 #include "ui/gl/android/surface_texture.h"
 #include "ui/gl/gl_surface.h"
 #include "ui/gl/gl_surface_stub.h"
 #include "webkit/common/gpu/context_provider_in_process.h"
 
 using gpu_blink::WebGraphicsContext3DImpl;
 using gpu_blink::WebGraphicsContext3DInProcessCommandBufferImpl;
 using webkit::gpu::ContextProviderWebContext;
 
 namespace content {
@@ skipping 31 matching lines @@
       in_process_attribs,
       gpu_preference,
       gpu::GLInProcessContextSharedMemoryLimits(),
       nullptr,
       nullptr));
   return context.Pass();
 }
 
 scoped_ptr<gpu::GLInProcessContext> CreateContext(
     scoped_refptr<gpu::InProcessCommandBuffer::Service> service,
-    const gpu::GLInProcessContextSharedMemoryLimits& mem_limits) {
+    const gpu::GLInProcessContextSharedMemoryLimits& mem_limits,
+    bool is_offscreen) {
   const gfx::GpuPreference gpu_preference = gfx::PreferDiscreteGpu;
   gpu::gles2::ContextCreationAttribHelper in_process_attribs;
   WebGraphicsContext3DImpl::ConvertAttributes(
       GetDefaultAttribs(), &in_process_attribs);
   in_process_attribs.lose_context_when_out_of_memory = true;
 
   scoped_ptr<gpu::GLInProcessContext> context(gpu::GLInProcessContext::Create(
       service,
       NULL /* surface */,
-      false /* is_offscreen */,
+      is_offscreen,
       gfx::kNullAcceleratedWidget,
       gfx::Size(1, 1),
       NULL /* share_context */,
       false /* share_resources */,
       in_process_attribs,
       gpu_preference,
       mem_limits,
       nullptr,
       nullptr));
   return context.Pass();
@@ skipping 123 matching lines @@
 }
 
 scoped_refptr<cc::ContextProvider> SynchronousCompositorFactoryImpl::
     CreateOnscreenContextProviderForCompositorThread() {
   DCHECK(service_.get());
 
   gpu::GLInProcessContextSharedMemoryLimits mem_limits;
   // This is half of what RenderWidget uses because synchronous compositor
   // pipeline is only one frame deep.
   mem_limits.mapped_memory_reclaim_limit = 6 * 1024 * 1024;
+
+  scoped_refptr<gpu::InProcessCommandBuffer::Service> service;
+  bool is_offscreen = true;
+  if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kEnableAsyncPixelWithThreadedTextureMailboxes)) {
+    service = service_;
+    is_offscreen = false;
+  }
   return webkit::gpu::ContextProviderInProcess::Create(
-      WrapContext(CreateContext(service_, mem_limits)),
+      WrapContext(CreateContext(service, mem_limits, is_offscreen)),
       "Child-Compositor");
 }
 
 scoped_refptr<StreamTextureFactory>
 SynchronousCompositorFactoryImpl::CreateStreamTextureFactory(int frame_id) {
   scoped_refptr<StreamTextureFactorySynchronousImpl> factory(
       StreamTextureFactorySynchronousImpl::Create(
           base::Bind(
               &SynchronousCompositorFactoryImpl::TryCreateStreamTextureFactory,
               base::Unretained(this)),
@@ skipping 48 matching lines @@
   // |video_context_provider_| to null is also not safe since it makes
   // synchronous destruction uncontrolled and possibly deadlock.
   if (!CanCreateMainThreadContext()) {
     return
         scoped_refptr<StreamTextureFactorySynchronousImpl::ContextProvider>();
   }
 
   if (!video_context_provider_.get()) {
     DCHECK(service_.get());
 
-    video_context_provider_ = new VideoContextProvider(
-        CreateContext(service_,
-                      gpu::GLInProcessContextSharedMemoryLimits()));
+    video_context_provider_ = new VideoContextProvider(CreateContext(
+        service_, gpu::GLInProcessContextSharedMemoryLimits(), false));

[no sievers, 2015/01/15 20:26:05]

Can you put a comment that this needs to be treated as 'onscreen' because it
runs in the shared onscreen context (due to SurfaceTexture limitations when it
comes to share groups and such)?

[boliu, 2015/01/21 02:08:01]

I put something generic. Can you look again?

What is the share group limitation? I thought the issue is SurfaceTexture uses
eglImages underneath so can't be shared across threads with mailboxes.

[no sievers, 2015/01/23 21:48:35]

Yes you cannot create another texture from a SurfaceTexture. You can only have
one and the API is a bit weird. For example, you can detach/attach it to a
different context, but then it will delete your texture (although the caller
created it). Also, it doesn't know about GL share groups but does a pointer
comparison (!) in many APIs for the context it's used with.

   }
   return video_context_provider_;
 }
 
 void SynchronousCompositorFactoryImpl::SetDeferredGpuService(
     scoped_refptr<gpu::InProcessCommandBuffer::Service> service) {
   DCHECK(!service_.get());
   service_ = service;
 }
 
 void SynchronousCompositorFactoryImpl::SetRecordFullDocument(
     bool record_full_document) {
   record_full_layer_ = record_full_document;
 }
 
 }  // namespace content