Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2391)

Unified Diff: chrome/browser/chromeos/settings/device_settings_service.h

Issue 769703003: SetManagementSettings() is moved to OwnerSettingsServiceChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Failing test fixed. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/settings/device_settings_service.h
diff --git a/chrome/browser/chromeos/settings/device_settings_service.h b/chrome/browser/chromeos/settings/device_settings_service.h
index 499190f0da45bd4cca512faff6022c3b0c84c67d..dbf315b65e3dfc02f1c466afc44a0d3f1d765b2a 100644
--- a/chrome/browser/chromeos/settings/device_settings_service.h
+++ b/chrome/browser/chromeos/settings/device_settings_service.h
@@ -131,16 +131,6 @@ class DeviceSettingsService : public SessionManagerClient::Observer {
// load the device settings.
void Load();
- // Sets the management related settings in PolicyData.
- //
- // TODO (ygorshenin@, crbug.com/230018): move this to the
- // OwnerSettingsService.
- void SetManagementSettings(
- enterprise_management::PolicyData::ManagementMode management_mode,
- const std::string& request_token,
- const std::string& device_id,
- const base::Closure& callback);
-
// Stores a policy blob to session_manager. The result of the operation is
// reported through |callback|. If successful, the updated device settings are
// present in policy_data() and device_settings() when the callback runs.
@@ -156,10 +146,20 @@ class DeviceSettingsService : public SessionManagerClient::Observer {
void GetOwnershipStatusAsync(const OwnershipStatusCallback& callback);
// Checks whether we have the private owner key.
+ //
+ // DEPRECATED (ygorshenin@, crbug.com/433840): this method should
+ // not be used since private key is a profile-specific resource and
+ // should be checked and used in a profile-aware manner, through
+ // OwnerSettingsService.
bool HasPrivateOwnerKey();
// Sets the identity of the user that's interacting with the service. This is
// relevant only for writing settings through SignAndStore().
+ //
+ // TODO (ygorshenin@, crbug.com/433840): get rid of the method when
+ // write path for device settings will be removed from
+ // DeviceSettingsProvider and all existing clients will be switched
+ // to OwnerSettingsServiceChromeOS.
void InitOwner(const std::string& username,
const base::WeakPtr<ownership::OwnerSettingsService>&
owner_settings_service);
@@ -187,13 +187,6 @@ class DeviceSettingsService : public SessionManagerClient::Observer {
// Enqueues a load operation.
void EnqueueLoad(bool force_key_load);
- // Enqueues a sign and store operation.
- //
- // TODO (ygorshenin@, crbug.com/433840): extract SetManagementSettings() out
- // of DeviceSettingsService and get rid of the method.
- void EnqueueSignAndStore(scoped_ptr<enterprise_management::PolicyData> policy,
- const base::Closure& callback);
-
// Makes sure there's a reload operation so changes to the settings (and key,
// in case force_key_load is set) are getting picked up.
void EnsureReload(bool force_key_load);

Powered by Google App Engine
This is Rietveld 408576698