Fix shared library build.

content/content_plugin.gypi

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       'target_name': 'content_plugin',
       'type': 'static_library',
       'dependencies': [
@@ skipping 39 matching lines @@
       'conditions': [
         ['OS=="win"', {
           'include_dirs': [
             '<(DEPTH)/third_party/wtl/include',
           ],
         }],
         ['toolkit_uses_gtk == 1', {
           'dependencies': [
             '../build/linux/system.gyp:gtk',
           ],
+          'link_settings': {
+            'libraries': [
+              '-lXext',

[jam, 2011/08/19 21:35:13]

I'm not familiar with this, so I defer to a Linux person

[Evan Martin, 2011/08/19 21:41:01]

For this kind of change it's sometimes helpful for a comment call out why these
extra dependencies are necessary.

I guess in this case it's because webplugin_proxy calls Xlib directly.

$ pwd; git grep XShm
/work/chrome/src/content/plugin
webplugin_proxy.cc:    XShmSegmentInfo shminfo = {0};
webplugin_proxy.cc:    *pixmap_out = XShmCreatePixmap(display, root_window,

[Paweł Hajdan Jr., 2011/08/19 21:47:41]

I was thinking about a comment, but there are several points in favor of not
doing it:

1) Existing gyp code doesn't comment on those (that'd be a bad excuse though)
2) It is likely to get out of date.
3) Maybe it should rather be something in system.gyp, instead of scattered
randomly throughout all the other gyp files. Like not "fix" the problem by
sticking a comment here, but just cleaning up the general linking with X11.

What do you think?

+            ],
+          },
         }],
       ],
     },
   ],
 }