runtime/vm/parser.cc - Issue 76963003: Fix crash evaluating metadata with super in a const constructor argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser.cc

Issue 76963003: Fix crash evaluating metadata with super in a const constructor argument. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/parser.cc

diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc

index 1bde3836f6d569ee4813a99eab900378b8e44c4c..ec66834826f717415247e292747f4a0a6c7ad090 100644

--- a/runtime/vm/parser.cc

+++ b/runtime/vm/parser.cc

@@ -10299,6 +10299,9 @@ AstNode* Parser::ParsePrimary() {

} else if (CurrentToken() == Token::kHASH) {

primary = ParseSymbolLiteral();

} else if (CurrentToken() == Token::kSUPER) {

+ if (parsing_metadata_) {

+ ErrorMsg("cannot access superclass from metadata");

+ }

if (current_function().is_static()) {

ErrorMsg("cannot access superclass from static method");

}

« no previous file with comments | « no previous file | tests/lib/mirrors/metadata_constructor_arguments_test.dart » ('j') | no next file with comments »