Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(47)

Issue 7696019: Merge 93441 - REGRESSION(r91628): 3 canvas tests crash on Chromium Linux and one test fail on Chr... (Closed)

Created:
9 years, 6 months ago by jamesr
Modified:
9 years, 6 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/835/
Visibility:
Public.

Description

Merge 93441 - REGRESSION(r91628): 3 canvas tests crash on Chromium Linux and one test fail on Chromium Mac https://bugs.webkit.org/show_bug.cgi?id=65063 Reviewed by Darin Fisher. Fixes crashes due to a bad cast from Image to BitmapImage on skia ports that use BitmapImageSingleFrameSkia. In the skia port Image::isBitmapImage() returning true does not necessarily mean that Image is of type BitmapImage. Covered by fast/canvas/canvas-as-image.html and many other canvas tests. Patch originally by Tom Hudson. * platform/graphics/BitmapImage.h: (WebCore::BitmapImage::currentFrameHasAlpha): (WebCore::BitmapImage::notSolidColor): * platform/graphics/Image.cpp: (WebCore::Image::drawTiled): * platform/graphics/Image.h: (WebCore::Image::currentFrameHasAlpha): (WebCore::Image::notSolidColor): * platform/graphics/skia/BitmapImageSingleFrameSkia.h: (WebCore::BitmapImageSingleFrameSkia::currentFrameHasAlpha): (WebCore::BitmapImageSingleFrameSkia::notSolidColor): * rendering/RenderImage.cpp: (WebCore::RenderImage::backgroundIsObscured): BUG=93558 TBR=jamesr@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93493

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8985 lines, -9 lines) Patch
M Source/WebCore/ChangeLog View 2 chunks +8967 lines, -1 line 0 comments Download
M Source/WebCore/platform/graphics/BitmapImage.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebCore/platform/graphics/Image.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/Image.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/graphics/skia/BitmapImageSingleFrameSkia.h View 2 chunks +9 lines, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderImage.cpp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jamesr
9 years, 6 months ago (2011-08-22 04:03:43 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698