Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/sibling/gyptest-all.py

Issue 7696003: ninja: land generator for ninja files (Closed) Base URL: https://gyp.googlecode.com/svn/trunk
Patch Set: fixes Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pylib/gyp/generator/ninja.py ('K') | « test/no-output/gyptest-no-output.py ('k') | test/sibling/gyptest-relocate.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/sibling/gyptest-all.py
diff --git a/test/sibling/gyptest-all.py b/test/sibling/gyptest-all.py
index c04c2d486117b062da2be1d22d7615f4c41b3187..7e80cf82361f732d8ad60e66b061030ae7a6cdc5 100644
--- a/test/sibling/gyptest-all.py
+++ b/test/sibling/gyptest-all.py
@@ -21,7 +21,7 @@ chdir = 'src/build'
# TODO(mmoss) Should the Makefile go in the directory of the passed in .gyp
# file? What about when passing in multiple .gyp files? Would sub-project
# Makefiles (see http://codereview.chromium.org/340008 comments) solve this?
-if test.format == 'make':
+if test.format in ('make', 'ninja'):
chdir = 'src'
if test.format == 'xcode':
« pylib/gyp/generator/ninja.py ('K') | « test/no-output/gyptest-no-output.py ('k') | test/sibling/gyptest-relocate.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698