Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: chrome/browser/ui/browser.cc

Issue 769593003: Move ZoomObserver, ZoomController and ZoomEventManager to components/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mac build fix #4. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 5c981d112ca0fe5d1ae2ac224ce49f5bd840f122..077924c72a46613123f58f5787d47f604ecc6bda 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -136,7 +136,6 @@
#include "chrome/browser/ui/webui/signin/login_ui_service.h"
#include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
#include "chrome/browser/ui/window_sizer/window_sizer.h"
-#include "chrome/browser/ui/zoom/zoom_controller.h"
#include "chrome/browser/upgrade_detector.h"
#include "chrome/browser/web_applications/web_app.h"
#include "chrome/common/chrome_constants.h"
@@ -182,6 +181,7 @@
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_system.h"
+#include "extensions/browser/ui/zoom/zoom_controller.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension.h"
#include "extensions/common/manifest_handlers/background_info.h"
@@ -1908,7 +1908,8 @@ void Browser::URLStarredChanged(content::WebContents* web_contents,
///////////////////////////////////////////////////////////////////////////////
// Browser, ZoomObserver implementation:
-void Browser::OnZoomChanged(const ZoomController::ZoomChangedEventData& data) {
+void Browser::OnZoomChanged(
+ const extensions::ZoomController::ZoomChangedEventData& data) {
if (data.web_contents == tab_strip_model_->GetActiveWebContents()) {
// Only show the zoom bubble for zoom changes in the active window.
window_->ZoomChangedForActiveTab(data.can_show_bubble &&
@@ -2276,10 +2277,12 @@ void Browser::SetAsDelegate(WebContents* web_contents, bool set_delegate) {
translate::ContentTranslateDriver& content_translate_driver =
ChromeTranslateClient::FromWebContents(web_contents)->translate_driver();
if (delegate) {
- ZoomController::FromWebContents(web_contents)->AddObserver(this);
+ extensions::ZoomController::FromWebContents(web_contents)
+ ->AddObserver(this);
content_translate_driver.AddObserver(translate_driver_observer_.get());
} else {
- ZoomController::FromWebContents(web_contents)->RemoveObserver(this);
+ extensions::ZoomController::FromWebContents(web_contents)
+ ->RemoveObserver(this);
content_translate_driver.RemoveObserver(translate_driver_observer_.get());
}
}

Powered by Google App Engine
This is Rietveld 408576698