Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Unified Diff: mojo/public/tests/buffer_unittest.cc

Issue 76943002: Have ScratchBuffer::Allocate prefer allocating on the stack even if a previous (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase to other CL Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/bindings/lib/buffer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/tests/buffer_unittest.cc
diff --git a/mojo/public/tests/buffer_unittest.cc b/mojo/public/tests/buffer_unittest.cc
index 7699962a30697298e38d9f639090caa4fac2c56d..3043b135c88458252053b1a4b34aeaa515c0cbd6 100644
--- a/mojo/public/tests/buffer_unittest.cc
+++ b/mojo/public/tests/buffer_unittest.cc
@@ -32,10 +32,9 @@ TEST(ScratchBufferTest, Basic) {
EXPECT_FALSE(large >= &buf && large < (&buf + sizeof(buf)));
// But another small allocation should be back on the stack.
- // TODO(mpcomplete): but it isn't. We can fix that easily enough.
small = buf.Allocate(10);
EXPECT_TRUE(IsZero(small, 10));
- //EXPECT_TRUE(small >= &buf && small < (&buf + sizeof(buf)));
+ EXPECT_TRUE(small >= &buf && small < (&buf + sizeof(buf)));
}
// Tests that FixedBuffer allocates memory aligned to 8 byte boundaries.
« no previous file with comments | « mojo/public/bindings/lib/buffer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698