Issue 76943002: Have ScratchBuffer::Allocate prefer allocating on the stack even if a previous

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 76943002: Have ScratchBuffer::Allocate prefer allocating on the stack even if a previous (Closed)

Created:
7 years, 1 month ago by Matt Perry

Modified:
7 years, 1 month ago

Reviewers:
darin (slow to review), DaveMoore

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Have ScratchBuffer::Allocate prefer allocating on the stack even if a previous allocation required the heap. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236389

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	mojo/public/bindings/lib/buffer.cc	View		1 chunk	+8 lines, -3 lines	0 comments	Download
	M	mojo/public/tests/buffer_unittest.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

Matt Perry

The unittest change here depends on https://codereview.chromium.org/67683004/

7 years, 1 month ago (2013-11-20 00:31:23 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/76943002/30001

7 years, 1 month ago (2013-11-20 21:44:47 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/76943002/30001

7 years, 1 month ago (2013-11-21 02:01:27 UTC) #4

Message was sent while issue was closed.

Change committed as 236389