Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 769423008: Impl-side painting for svg/ layout tests (Closed)

Created:
6 years ago by enne (OOO)
Modified:
6 years ago
Reviewers:
chrishtr
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, dstockwell, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh
Project:
blink
Visibility:
Public.

Description

Impl-side painting for svg/ layout tests Dearest Blink gardener, this will likely cause slight pixel differences on Mac bots and other bots that don't have try server support. If results are imperceptibly the same (especially on tests with opacity, gradients, shadows, etc), these can all be rebaselined. BUG=381919 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186557

Patch Set 1 #

Patch Set 2 : Updated expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+371 lines, -52 lines) Patch
M LayoutTests/TestExpectations View 1 3 chunks +366 lines, -6 lines 0 comments Download
D LayoutTests/svg/animations/animateMotion-accumulate-2b-expected.svg View 1 chunk +0 lines, -21 lines 0 comments Download
M LayoutTests/svg/canvas/canvas-draw-image-globalalpha.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/canvas/canvas-draw-image-globalalpha-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/foreignObject/clip.html View 1 chunk +2 lines, -2 lines 0 comments Download
D LayoutTests/svg/foreignObject/clip-expected.html View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/svg/foreignObject/filter-expected.html View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/svg/foreignObject/mask-expected.html View 1 chunk +0 lines, -7 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
enne (OOO)
6 years ago (2014-12-04 23:12:42 UTC) #2
chrishtr
lgtm
6 years ago (2014-12-04 23:25:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/769423008/20001
6 years ago (2014-12-04 23:26:39 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-05 00:58:44 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186557

Powered by Google App Engine
This is Rietveld 408576698