Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 769413004: Switch icu repo to icu.git from icu52.git (Closed)

Created:
6 years ago by jungshik at Google
Modified:
6 years ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Switch icu repo to icu.git from icu52.git We're switching from svn to git for icu and dropping the icu major version number from the repo name. Besides, roll ICU to 53ecf0f68b27a004bef5526553b8e5f6c235b80b (adding codereview.settings ; https://codereview.chromium.org/775153003/ BUG=438401 TEST=gclient sync succeeds and third_party/icu comes from icu.git instead of icu52.git TBR=vadimsh@chromium.org Committed: https://crrev.com/b0a58a7eb0001b434824c7d7dbf49a85cbb17561 Cr-Commit-Position: refs/heads/master@{#306910}

Patch Set 1 #

Patch Set 2 : roll icu to 53ecf0f68b (codereview.settings) #

Patch Set 3 : fix hash to icu.git #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
jungshik at Google
6 years ago (2014-12-04 00:42:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/769413004/20001
6 years ago (2014-12-04 00:44:40 UTC) #4
Vadim Sh.
lgtm
6 years ago (2014-12-04 00:44:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/22866) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/4113) mac_chromium_rel_ng ...
6 years ago (2014-12-04 01:10:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/769413004/40001
6 years ago (2014-12-04 20:58:59 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-04 22:26:47 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-04 22:27:38 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b0a58a7eb0001b434824c7d7dbf49a85cbb17561
Cr-Commit-Position: refs/heads/master@{#306910}

Powered by Google App Engine
This is Rietveld 408576698