Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 7694018: Don't generate absolute references under nacl-x64. (Closed)

Created:
9 years, 4 months ago by khim
Modified:
9 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-gcc.git@master
Visibility:
Public.

Description

Don't generate absolute references under nacl-x64. All NaCl modules are PIC to some degree: they can use constant offsets when statically linked, but these offsets must be relative to %r15. movabs* with memory operand can never be used. R=eaeltsin@google.com Committed: http://git.chromium.org/gitweb?p=native_client/nacl-gcc.git;a=commit;h=735dddb

Patch Set 1 #

Patch Set 2 : Added comment to i386.c file itself #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M gcc/config/i386/i386.c View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
khim
9 years, 4 months ago (2011-08-20 14:28:59 UTC) #1
eaeltsin
lgtm
9 years, 4 months ago (2011-08-26 17:01:52 UTC) #2
Mark Seaborn
On 20 August 2011 07:28, <khim@chromium.org> wrote: > Reviewers: eaeltsin, > > Description: > Don't ...
9 years, 4 months ago (2011-08-26 20:06:06 UTC) #3
sehr (please use chromium)
It was turned up by Robert during Mame porting, I believe. David On Fri, Aug ...
9 years, 4 months ago (2011-08-26 20:31:29 UTC) #4
khim
9 years, 4 months ago (2011-08-26 21:06:56 UTC) #5
On Sat, Aug 27, 2011 at 12:31 AM, David Sehr <sehr@google.com> wrote:

> It was turned up by Robert during Mame porting, I believe.
>
> Yup. I'm not exactly sure what you need to do to force this codepath: I
have some kind of large reproducer, but I'm not sure I can use it
(copyright-wise) for our tests.


> David
>
> On Fri, Aug 26, 2011 at 1:06 PM, Mark Seaborn <mseaborn@chromium.org>wrote:
>
>> On 20 August 2011 07:28, <khim@chromium.org> wrote:
>>
>>> Reviewers: eaeltsin,
>>>
>>> Description:
>>> Don't generate absolute references under nacl-x64.
>>>
>>> All NaCl modules are PIC to some degree: they can use constant offsets
>>> when statically linked, but these offsets must be relative to %r15.
>>> movabs* with memory operand can never be used.
>>>
>>
>> Is this fixing a bug?  If so, how can this be tested?  Or is this a
>> just-in-case change?
>>
>> Mark
>>
>>  --
>> You received this message because you are subscribed to the Google Groups
>> "Native-Client-Reviews" group.
>> To post to this group, send email to
>> native-client-reviews@googlegroups.com.
>> To unsubscribe from this group, send email to
>> native-client-reviews+unsubscribe@googlegroups.com.
>> For more options, visit this group at
>> http://groups.google.com/group/native-client-reviews?hl=en.
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

Powered by Google App Engine
This is Rietveld 408576698