Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 7694002: Make sure Backspace in a text field in an infobar does not navigate back one page. (Closed)

Created:
9 years, 4 months ago by Finnur
Modified:
9 years, 4 months ago
Reviewers:
Jay Civelli
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Make sure Backspace in a text field in an infobar does not navigate back one page. BUG=42453 TEST=I'll update the bug with a test extension. Basically, on Windows, navigate to at least two pages. Then show the infobar (hint: browser action), set focus to the input text box in the infobar and press Backspace. Page should not navigate back. Now click on the page content and press Back: it should navigate back. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97617

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/ui/views/extensions/extension_view.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
9 years, 4 months ago (2011-08-19 17:18:41 UTC) #1
Jay Civelli
9 years, 4 months ago (2011-08-19 17:20:55 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698