Minor visual improvements to text selection UI

content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/touch_editable_impl_aura.h"
 
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/test_timeouts.h"
@@ skipping 186 matching lines @@
   value->GetAsString(&selection);
 
   // Check if selection handles are showing.
   EXPECT_TRUE(GetTouchSelectionController(touch_editable));
   EXPECT_STREQ("Some text we can select", selection.c_str());
 
   // Lets move the handles a bit to modify the selection
   touch_editable->Reset();
   ui::SelectionBound anchor, focus;
   touch_editable->GetSelectionEndPoints(&anchor, &focus);
+  // The distance by which a handle image is offset from the bottom of the
+  // selection/text baseline.
+  const int kSelectionHandleVerticalVisualOffset = 2;
   int handle_grab_x = bounds.x() + anchor.edge_bottom_rounded().x();
-  int handle_grab_y = bounds.y() + anchor.edge_bottom_rounded().y() + 1;
+  int handle_grab_y = bounds.y() + anchor.edge_bottom_rounded().y() +
+                      kSelectionHandleVerticalVisualOffset + 1;
   generator.GestureScrollSequence(
       gfx::Point(handle_grab_x, handle_grab_y),
       gfx::Point(handle_grab_x + 20, handle_grab_y),
       base::TimeDelta::FromMilliseconds(20),
       5);
   touch_editable->WaitForSelectionChangeCallback();
 
   EXPECT_TRUE(GetTouchSelectionController(touch_editable));
   value = content::ExecuteScriptAndGetValue(main_frame, "get_selection()");
   value->GetAsString(&selection);
@@ skipping 236 matching lines @@
   value = content::ExecuteScriptAndGetValue(main_frame,
                                             "get_cursor_position()");
   int new_cursor_pos = -1;
   value->GetAsInteger(&new_cursor_pos);
   EXPECT_NE(-1, new_cursor_pos);
   // Cursor should have moved.
   EXPECT_NE(new_cursor_pos, cursor_pos);
 }
 
 }  // namespace content