content/browser/web_contents/web_contents_impl.cc - Issue 769363002: Initialize BrowserPluginGuest to attach to the View hierarchy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 769363002: Initialize BrowserPluginGuest to attach to the View hierarchy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@basic_detach_plumbing

Patch Set: Don't initialize by default Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/browser_plugin/browser_plugin_guest.cc ('K') | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/public/browser/browser_plugin_guest_delegate.h » ('j') | content/public/browser/browser_plugin_guest_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 4a738e6ac1d7f07b483b88869c78425e97058adf..f57a9d30155626361c211814a07f5ee32f971a74 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -1196,6 +1196,9 @@ void WebContentsImpl::Init(const WebContents::CreateParams& params) {

#if defined(OS_ANDROID)

date_time_chooser_.reset(new DateTimeChooserAndroid());

#endif

+ if (browser_plugin_guest_)

lazyboy 2014/12/04 16:51:13 You need to run Init() after |view_->CreateView()|

Fady Samuel 2014/12/04 20:54:44 Done.

+ browser_plugin_guest_->Init();

}

void WebContentsImpl::OnWebContentsDestroyed(WebContentsImpl* web_contents) {