extensions/browser/guest_view/guest_view_base.h - Issue 769363002: Initialize BrowserPluginGuest to attach to the View hierarchy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/guest_view_base.h

Issue 769363002: Initialize BrowserPluginGuest to attach to the View hierarchy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@basic_detach_plumbing

Patch Set: Addressed Charlie's comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/guest_view/guest_view_base.h

diff --git a/extensions/browser/guest_view/guest_view_base.h b/extensions/browser/guest_view/guest_view_base.h

index 12562aedf4ff1a55dc83ae941cecc95e841d6bd7..52e764803162c5ffc0a2aa47b270dfc84aa357db 100644

--- a/extensions/browser/guest_view/guest_view_base.h

+++ b/extensions/browser/guest_view/guest_view_base.h

@@ -241,6 +241,7 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,

void DidDetach() final;

void ElementSizeChanged(const gfx::Size& old_size,

const gfx::Size& new_size) final;

+ content::WebContents* GetOwnerWebContents() const final;

void GuestSizeChanged(const gfx::Size& old_size,

const gfx::Size& new_size) final;

void RegisterDestructionCallback(const DestructionCallback& callback) final;

« no previous file with comments | « content/public/browser/browser_plugin_guest_delegate.cc ('k') | extensions/browser/guest_view/guest_view_base.cc » ('j') | no next file with comments »