src/utils.h - Issue 769263002: Add support for enabling DCHECKs in release mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils.h

Issue 769263002: Add support for enabling DCHECKs in release mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils.h

diff --git a/src/utils.h b/src/utils.h

index d5685c98207d3a2211919f4a0dbbafef2b980304..9ca291a75bbddc48cb55469b52eecbd5d3d98693 100644

--- a/src/utils.h

+++ b/src/utils.h

@@ -37,7 +37,7 @@ inline bool CStringEquals(const char* s1, const char* s2) {

inline int WhichPowerOf2(uint32_t x) {

DCHECK(base::bits::IsPowerOfTwo32(x));

int bits = 0;

-#ifdef DEBUG

+#if DCHECK_IS_ON

int original_x = x;

#endif

if (x >= 0x10000) {

« no previous file with comments | « src/transitions.h ('k') | src/x64/assembler-x64.cc » ('j') | no next file with comments »