src/parser.cc - Issue 769263002: Add support for enabling DCHECKs in release mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parser.cc

Issue 769263002: Add support for enabling DCHECKs in release mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parser.cc

diff --git a/src/parser.cc b/src/parser.cc

index 6fcca2070bf27b7e8d8b95147a5a7b39c77ac696..0469a2653f57443b97ef512b92c60eb40921655f 100644

--- a/src/parser.cc

+++ b/src/parser.cc

@@ -29,10 +29,12 @@ RegExpBuilder::RegExpBuilder(Zone* zone)

characters_(NULL),

terms_(),

alternatives_()

-#ifdef DEBUG

- , last_added_(ADD_NONE)

+#if DCHECK_IS_ON

+ ,

+ last_added_(ADD_NONE)

#endif

- {}

void RegExpBuilder::FlushCharacters() {

@@ -4705,7 +4707,7 @@ RegExpTree* RegExpParser::ParseDisjunction() {

}

-#ifdef DEBUG

+#if DCHECK_IS_ON

// Currently only used in an DCHECK.

static bool IsSpecialClassEscape(uc32 c) {

switch (c) {

« no previous file with comments | « src/parser.h ('k') | src/ppc/codegen-ppc.cc » ('j') | no next file with comments »