src/json-parser.h - Issue 769263002: Add support for enabling DCHECKs in release mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/json-parser.h

Issue 769263002: Add support for enabling DCHECKs in release mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/json-parser.h

diff --git a/src/json-parser.h b/src/json-parser.h

index 5ebbcdd861b351bc072d08ba209037bc1ed36678..40c381a87ea1c20be013526068e86b244e59e18c 100644

--- a/src/json-parser.h

+++ b/src/json-parser.h

@@ -348,7 +348,7 @@ Handle<Object> JsonParser<seq_one_byte>::ParseJsonObject() {

}

position_ = start_position;

-#ifdef DEBUG

+#if DCHECK_IS_ON

c0_ = '"';

#endif

@@ -769,7 +769,7 @@ Handle<String> JsonParser<seq_one_byte>::ScanJsonString() {

if (element != isolate()->heap()->the_hole_value() &&

String::cast(element)->IsOneByteEqualTo(string_vector)) {

result = Handle<String>(String::cast(element), isolate());

-#ifdef DEBUG

+#if DCHECK_IS_ON

uint32_t hash_field =

(hash << String::kHashShift) | String::kIsNotArrayIndexMask;

DCHECK_EQ(static_cast<int>(result->Hash()),

« no previous file with comments | « src/isolate.cc ('k') | src/layout-descriptor.h » ('j') | no next file with comments »