Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: src/hydrogen-instructions.h

Issue 769263002: Add support for enabling DCHECKs in release mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/hydrogen-flow-engine.h ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index b56e9215ab35d5d4c22b11f8eab3af9128fc6e58..1c5bd808fbc3c5714de6e7d2596ac8907ed00fd5 100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -259,7 +259,7 @@ class Range FINAL : public ZoneObject {
upper_ = Min(upper_, Smi::kMaxValue);
}
void KeepOrder();
-#ifdef DEBUG
+#if DCHECK_IS_ON
void Verify() const;
#endif
@@ -559,7 +559,7 @@ class HValue : public ZoneObject {
type_(type),
use_list_(NULL),
range_(NULL),
-#ifdef DEBUG
+#if DCHECK_IS_ON
range_poisoned_(false),
#endif
flags_(0) {}
@@ -739,7 +739,7 @@ class HValue : public ZoneObject {
DCHECK(!range_poisoned_);
return range_ != NULL;
}
-#ifdef DEBUG
+#if DCHECK_IS_ON
void PoisonRange() { range_poisoned_ = true; }
#endif
void AddNewRange(Range* r, Zone* zone);
@@ -803,7 +803,7 @@ class HValue : public ZoneObject {
return HasObservableSideEffects() || !IsDeletable();
}
-#ifdef DEBUG
+#if DCHECK_IS_ON
virtual void Verify() = 0;
#endif
@@ -916,7 +916,7 @@ class HValue : public ZoneObject {
HType type_;
HUseListNode* use_list_;
Range* range_;
-#ifdef DEBUG
+#if DCHECK_IS_ON
bool range_poisoned_;
#endif
int flags_;
@@ -1196,7 +1196,7 @@ class HInstruction : public HValue {
virtual LInstruction* CompileToLithium(LChunkBuilder* builder) = 0;
-#ifdef DEBUG
+#if DCHECK_IS_ON
virtual void Verify() OVERRIDE;
#endif
@@ -1875,7 +1875,7 @@ class HSimulate FINAL : public HInstruction {
DECLARE_CONCRETE_INSTRUCTION(Simulate)
-#ifdef DEBUG
+#if DCHECK_IS_ON
virtual void Verify() OVERRIDE;
void set_closure(Handle<JSFunction> closure) { closure_ = closure; }
Handle<JSFunction> closure() const { return closure_; }
@@ -1919,7 +1919,7 @@ class HSimulate FINAL : public HInstruction {
Zone* zone_;
uint32_t bit_field_;
-#ifdef DEBUG
+#if DCHECK_IS_ON
Handle<JSFunction> closure_;
#endif
};
@@ -1944,7 +1944,7 @@ class HEnvironmentMarker FINAL : public HTemplateInstruction<1> {
virtual std::ostream& PrintDataTo(std::ostream& os) const OVERRIDE; // NOLINT
-#ifdef DEBUG
+#if DCHECK_IS_ON
void set_closure(Handle<JSFunction> closure) {
DCHECK(closure_.is_null());
DCHECK(!closure.is_null());
@@ -1963,7 +1963,7 @@ class HEnvironmentMarker FINAL : public HTemplateInstruction<1> {
int index_;
HSimulate* next_simulate_;
-#ifdef DEBUG
+#if DCHECK_IS_ON
Handle<JSFunction> closure_;
#endif
};
@@ -2910,7 +2910,7 @@ class HCheckValue FINAL : public HUnaryOperation {
virtual HValue* Canonicalize() OVERRIDE;
-#ifdef DEBUG
+#if DCHECK_IS_ON
virtual void Verify() OVERRIDE;
#endif
@@ -3046,7 +3046,7 @@ class HCheckHeapObject FINAL : public HUnaryOperation {
return HType::HeapObject();
}
-#ifdef DEBUG
+#if DCHECK_IS_ON
virtual void Verify() OVERRIDE;
#endif
@@ -3347,7 +3347,7 @@ class HPhi FINAL : public HValue {
virtual std::ostream& PrintTo(std::ostream& os) const OVERRIDE; // NOLINT
-#ifdef DEBUG
+#if DCHECK_IS_ON
virtual void Verify() OVERRIDE;
#endif
@@ -3739,7 +3739,7 @@ class HConstant FINAL : public HTemplateInstruction<0> {
}
}
-#ifdef DEBUG
+#if DCHECK_IS_ON
virtual void Verify() OVERRIDE { }
#endif
@@ -7677,7 +7677,7 @@ class HToFastProperties FINAL : public HUnaryOperation {
// change the map of the input operand. Use it only when creating
// object literals via a runtime call.
DCHECK(value->IsCallRuntime());
-#ifdef DEBUG
+#if DCHECK_IS_ON
const Runtime::Function* function = HCallRuntime::cast(value)->function();
DCHECK(function->function_id == Runtime::kCreateObjectLiteral);
#endif
« no previous file with comments | « src/hydrogen-flow-engine.h ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698