src/heap/store-buffer.cc - Issue 769263002: Add support for enabling DCHECKs in release mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/store-buffer.cc

Issue 769263002: Add support for enabling DCHECKs in release mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/store-buffer.cc

diff --git a/src/heap/store-buffer.cc b/src/heap/store-buffer.cc

index 5fd4ce34f3aee6913c42fe3c292b1dea5f0ea8ab..c346c14e62fa9537e418f131a758232f8db7f4c1 100644

--- a/src/heap/store-buffer.cc

+++ b/src/heap/store-buffer.cc

@@ -399,7 +399,7 @@ void StoreBuffer::IteratePointersInStoreBuffer(ObjectSlotCallback slot_callback,

{

DontMoveStoreBufferEntriesScope scope(this);

for (Address* current = old_start_; current < limit; current++) {

-#ifdef DEBUG

+#if DCHECK_IS_ON

Address* saved_top = old_top_;

#endif

Object** slot = reinterpret_cast<Object**>(*current);

« no previous file with comments | « src/heap/spaces.cc ('k') | src/hydrogen.h » ('j') | no next file with comments »