src/handles.h - Issue 769263002: Add support for enabling DCHECKs in release mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/handles.h

Issue 769263002: Add support for enabling DCHECKs in release mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/handles.h

diff --git a/src/handles.h b/src/handles.h

index eb57f0e26089383c9d7fe9f57a8cba5f41a111e2..6a485af026d923607bc2172ceaebae78b3caeb9b 100644

--- a/src/handles.h

+++ b/src/handles.h

@@ -128,11 +128,11 @@ class Handle {

// implementation in api.h.

inline Handle<T> EscapeFrom(v8::EscapableHandleScope* scope);

-#ifdef DEBUG

+#ifdef ENABLE_SLOW_DCHECKS

enum DereferenceCheckMode { INCLUDE_DEFERRED_CHECK, NO_DEFERRED_CHECK };

bool IsDereferenceAllowed(DereferenceCheckMode mode) const;

-#endif // DEBUG

+#endif // ENABLE_SLOW_DCHECKS

private:

T** location_;

@@ -256,7 +256,7 @@ class DeferredHandleScope {

Object** prev_next_;

HandleScopeImplementer* impl_;

-#ifdef DEBUG

+#if DCHECK_IS_ON

bool handles_detached_;

int prev_level_;

#endif

« no previous file with comments | « src/full-codegen.cc ('k') | src/handles.cc » ('j') | no next file with comments »