src/full-codegen.cc - Issue 769263002: Add support for enabling DCHECKs in release mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen.cc

Issue 769263002: Add support for enabling DCHECKs in release mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen.cc

diff --git a/src/full-codegen.cc b/src/full-codegen.cc

index cb8f4aafcd9cd7274f032f14505f5dd028725252..77f173d91c375a443604f1e1415976f324523217 100644

--- a/src/full-codegen.cc

+++ b/src/full-codegen.cc

@@ -1759,7 +1759,7 @@ void BackEdgeTable::RemoveStackCheck(Handle<Code> code, uint32_t pc_offset) {

}

-#ifdef DEBUG

+#if DCHECK_IS_ON

bool BackEdgeTable::Verify(Isolate* isolate, Code* unoptimized) {

DisallowHeapAllocation no_gc;

int loop_nesting_level = unoptimized->allow_osr_at_loop_nesting_level();

@@ -1776,7 +1776,7 @@ bool BackEdgeTable::Verify(Isolate* isolate, Code* unoptimized) {

}

return true;

}

-#endif // DEBUG

+#endif // DCHECK_IS_ON

FullCodeGenerator::EnterBlockScopeIfNeeded::EnterBlockScopeIfNeeded(

« no previous file with comments | « src/full-codegen.h ('k') | src/handles.h » ('j') | no next file with comments »