Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: src/deoptimizer.cc

Issue 769263002: Add support for enabling DCHECKs in release mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/deoptimizer.h ('k') | src/flag-definitions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/deoptimizer.cc
diff --git a/src/deoptimizer.cc b/src/deoptimizer.cc
index 554ba8e7b17f272e5f4dbfbad51df460343bcc8a..c518578340144431c48692884182919bd1389666 100644
--- a/src/deoptimizer.cc
+++ b/src/deoptimizer.cc
@@ -605,10 +605,10 @@ Deoptimizer::Deoptimizer(Isolate* isolate,
: StackFrame::JAVA_SCRIPT;
trace_scope_ = TraceEnabledFor(type, frame_type) ?
new CodeTracer::Scope(isolate->GetCodeTracer()) : NULL;
-#ifdef DEBUG
- CHECK(AllowHeapAllocation::IsAllowed());
+#if DCHECK_IS_ON
+ DCHECK(AllowHeapAllocation::IsAllowed());
disallow_heap_allocation_ = new DisallowHeapAllocation();
-#endif // DEBUG
+#endif // DCHECK_IS_ON
unsigned size = ComputeInputFrameSize();
input_ = new(size) FrameDescription(size, function);
input_->SetFrameType(frame_type);
@@ -660,12 +660,12 @@ void Deoptimizer::DeleteFrameDescriptions() {
delete[] output_;
input_ = NULL;
output_ = NULL;
-#ifdef DEBUG
- CHECK(!AllowHeapAllocation::IsAllowed());
- CHECK(disallow_heap_allocation_ != NULL);
+#if DCHECK_IS_ON
+ DCHECK(!AllowHeapAllocation::IsAllowed());
+ DCHECK(disallow_heap_allocation_ != NULL);
delete disallow_heap_allocation_;
disallow_heap_allocation_ = NULL;
-#endif // DEBUG
+#endif // DCHECK_IS_ON
}
« no previous file with comments | « src/deoptimizer.h ('k') | src/flag-definitions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698