src/builtins.cc - Issue 769263002: Add support for enabling DCHECKs in release mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.cc

Issue 769263002: Add support for enabling DCHECKs in release mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins.cc

diff --git a/src/builtins.cc b/src/builtins.cc

index b8d0b42d50e8f757497c12696d5112b1d03043b8..4764ef21fbfb178cb0d9f0a6570081dac395c71c 100644

--- a/src/builtins.cc

+++ b/src/builtins.cc

@@ -132,7 +132,7 @@ BUILTIN_LIST_C(DEF_ARG_TYPE)

#endif

-#ifdef DEBUG

+#if DCHECK_IS_ON

static inline bool CalledAsConstructor(Isolate* isolate) {

// Calculate the result using a full stack frame iterator and check

// that the state of the stack is as we assume it to be in the

« no previous file with comments | « src/bignum.cc ('k') | src/cached-powers.cc » ('j') | no next file with comments »