src/base/platform/mutex.h - Issue 769263002: Add support for enabling DCHECKs in release mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/base/platform/mutex.h

Issue 769263002: Add support for enabling DCHECKs in release mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/base/platform/mutex.h

diff --git a/src/base/platform/mutex.h b/src/base/platform/mutex.h

index 5d0e57be57cb8141eee5fceaa37581b0679c6e46..01e9c3d17eb6d001d634bbc408d573f6c730bf7c 100644

--- a/src/base/platform/mutex.h

+++ b/src/base/platform/mutex.h

@@ -68,19 +68,19 @@ class Mutex FINAL {

private:

NativeHandle native_handle_;

-#ifdef DEBUG

+#if DCHECK_IS_ON

int level_;

#endif

V8_INLINE void AssertHeldAndUnmark() {

-#ifdef DEBUG

+#if DCHECK_IS_ON

DCHECK_EQ(1, level_);

level_--;

#endif

}

V8_INLINE void AssertUnheldAndMark() {

-#ifdef DEBUG

+#if DCHECK_IS_ON

DCHECK_EQ(0, level_);

level_++;

#endif

@@ -163,7 +163,7 @@ class RecursiveMutex FINAL {

private:

NativeHandle native_handle_;

-#ifdef DEBUG

+#if DCHECK_IS_ON

int level_;

#endif

« no previous file with comments | « src/base/platform/elapsed-timer.h ('k') | src/base/platform/mutex.cc » ('j') | no next file with comments »