src/arm/codegen-arm.cc - Issue 769263002: Add support for enabling DCHECKs in release mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/codegen-arm.cc

Issue 769263002: Add support for enabling DCHECKs in release mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/codegen-arm.cc

diff --git a/src/arm/codegen-arm.cc b/src/arm/codegen-arm.cc

index fd1b0efc8d8d2c0e6924dff84efc6cba31776a65..2ea5c7d9736f874782b1348d3783eced1842a4ea 100644

--- a/src/arm/codegen-arm.cc

+++ b/src/arm/codegen-arm.cc

@@ -900,7 +900,7 @@ CodeAgingHelper::CodeAgingHelper() {

}

-#ifdef DEBUG

+#if DCHECK_IS_ON

bool CodeAgingHelper::IsOld(byte* candidate) const {

return Memory::uint32_at(candidate) == kCodeAgePatchFirstInstruction;

}

« no previous file with comments | « src/api.cc ('k') | src/arm64/codegen-arm64.cc » ('j') | no next file with comments »