Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1777)

Unified Diff: src/objects.cc

Issue 769263002: Add support for enabling DCHECKs in release mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index d3e58e8a000da26a8c20b52cd1b54a3582db701c..b53f986233af257fc3d894c9f1586bd75ad6f737 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -1068,7 +1068,7 @@ bool String::MakeExternal(v8::String::ExternalStringResource* resource) {
resource->data(),
resource->length() * sizeof(smart_chars[0])) == 0);
}
-#endif // DEBUG
+#endif // ENABLE_SLOW_DCHECKS
Jakob Kummerow 2014/12/03 10:53:53 nit: does clang-format stop being stupid when you
int size = this->Size(); // Byte size of the original string.
// Abort if size does not allow in-place conversion.
if (size < ExternalString::kShortSize) return false;
@@ -1135,7 +1135,7 @@ bool String::MakeExternal(v8::String::ExternalOneByteStringResource* resource) {
resource->data(),
resource->length() * sizeof(smart_chars[0])) == 0);
}
-#endif // DEBUG
+#endif // ENABLE_SLOW_DCHECKS
int size = this->Size(); // Byte size of the original string.
// Abort if size does not allow in-place conversion.
if (size < ExternalString::kShortSize) return false;
@@ -12016,7 +12016,7 @@ Handle<Map> Map::TransitionToPrototype(Handle<Map> map,
MaybeHandle<Object> JSObject::SetPrototype(Handle<JSObject> object,
Handle<Object> value,
bool from_javascript) {
-#ifdef DEBUG
+#if DCHECK_IS_ON
int size = object->Size();
#endif
« src/lithium-allocator.cc ('K') | « src/objects.h ('k') | src/objects-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698