Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: src/hydrogen.cc

Issue 769263002: Add support for enabling DCHECKs in release mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index f2ce8a1c9b90e28b4a0976913b1f2608fe102ada..0d822c8462b0024d0479e6c683145d87ac3d91cd 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -176,7 +176,7 @@ HSimulate* HBasicBlock::CreateSimulate(BailoutId ast_id,
HSimulate* instr =
new(zone()) HSimulate(ast_id, pop_count, zone(), removable);
-#ifdef DEBUG
+#if DCHECK_IS_ON
instr->set_closure(environment->closure());
#endif
// Order of pushed values: newest (top of stack) first. This allows
@@ -462,7 +462,7 @@ int HBasicBlock::PredecessorIndexOf(HBasicBlock* predecessor) const {
}
-#ifdef DEBUG
+#if DCHECK_IS_ON
void HBasicBlock::Verify() {
// Check that every block is finished.
DCHECK(IsFinished());
@@ -513,7 +513,7 @@ void HLoopInformation::AddBlock(HBasicBlock* block) {
}
-#ifdef DEBUG
+#if DCHECK_IS_ON
// Checks reachability of the blocks in this graph and stores a bit in
// the BitVector "reachable()" for every block that can be reached
@@ -3851,7 +3851,7 @@ class PostorderProcessor : public ZoneObject {
void HGraph::OrderBlocks() {
CompilationPhase phase("H_Block ordering", info());
-#ifdef DEBUG
+#if DCHECK_IS_ON
// Initially the blocks must not be ordered.
for (int i = 0; i < blocks_.length(); ++i) {
DCHECK(!blocks_[i]->IsOrdered());
@@ -3865,7 +3865,7 @@ void HGraph::OrderBlocks() {
postorder = postorder->PerformStep(zone(), &blocks_);
}
-#ifdef DEBUG
+#if DCHECK_IS_ON
// Now all blocks must be marked as ordered.
for (int i = 0; i < blocks_.length(); ++i) {
DCHECK(blocks_[i]->IsOrdered());
@@ -4014,7 +4014,7 @@ AstContext::AstContext(HOptimizedGraphBuilder* owner, Expression::Context kind)
outer_(owner->ast_context()),
for_typeof_(false) {
owner->set_ast_context(this); // Push.
-#ifdef DEBUG
+#if DCHECK_IS_ON
DCHECK(owner->environment()->frame_type() == JS_FUNCTION);
original_length_ = owner->environment()->length();
#endif
@@ -4375,7 +4375,7 @@ bool HGraph::Optimize(BailoutReason* bailout_reason) {
// evaluates relations with "zero" and that zero cannot be created after GVN.
GetConstant0();
-#ifdef DEBUG
+#if DCHECK_IS_ON
// Do a full verify after building the graph and computing dominators.
Verify(true);
#endif
@@ -4460,7 +4460,7 @@ void HGraph::RestoreActualValues() {
for (int block_index = 0; block_index < blocks()->length(); block_index++) {
HBasicBlock* block = blocks()->at(block_index);
-#ifdef DEBUG
+#if DCHECK_IS_ON
for (int i = 0; i < block->phis()->length(); i++) {
HPhi* phi = block->phis()->at(i);
DCHECK(phi->ActualValue() == phi);
@@ -13020,7 +13020,7 @@ HPhase::~HPhase() {
isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
}
-#ifdef DEBUG
+#if DCHECK_IS_ON
graph_->Verify(false); // No full verify.
#endif
}

Powered by Google App Engine
This is Rietveld 408576698