src/compiler/register-allocator.cc - Issue 769263002: Add support for enabling DCHECKs in release mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/register-allocator.cc

Issue 769263002: Add support for enabling DCHECKs in release mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/register-allocator.cc

diff --git a/src/compiler/register-allocator.cc b/src/compiler/register-allocator.cc

index 6c67ff40d400e1e687764516f379b4b24aad0e64..42e846c12eb2d82ca7774dca67916cb55e8fc0f7 100644

--- a/src/compiler/register-allocator.cc

+++ b/src/compiler/register-allocator.cc

@@ -1841,7 +1841,7 @@ void RegisterAllocator::AllocateRegisters() {

LiveRange* current = unhandled_live_ranges_.RemoveLast();

DCHECK(UnhandledIsSorted());

LifetimePosition position = current->Start();

-#ifdef DEBUG

+#if DCHECK_IS_ON

allocation_finger_ = position;

#endif

TraceAlloc("Processing interval %d start=%d\n", current->id(),