Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: src/assert-scope.h

Issue 769263002: Add support for enabling DCHECKs in release mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/assert-scope.h
diff --git a/src/assert-scope.h b/src/assert-scope.h
index 0f1e056fbac711ecc82e937a858e021f1a91574c..e81a3647d7029ff5779e11a36725c386766c6241 100644
--- a/src/assert-scope.h
+++ b/src/assert-scope.h
@@ -70,9 +70,8 @@ class PerIsolateAssertScope {
template <PerThreadAssertType type, bool allow>
-#ifdef DEBUG
-class PerThreadAssertScopeDebugOnly : public
- PerThreadAssertScope<type, allow> {
+#if DCHECK_IS_ON
+class PerThreadAssertScopeDebugOnly : public PerThreadAssertScope<type, allow> {
#else
class PerThreadAssertScopeDebugOnly {
public:
@@ -82,9 +81,9 @@ class PerThreadAssertScopeDebugOnly {
template <PerIsolateAssertType type, bool allow>
-#ifdef DEBUG
-class PerIsolateAssertScopeDebugOnly : public
- PerIsolateAssertScope<type, allow> {
+#if DCHECK_IS_ON
+class PerIsolateAssertScopeDebugOnly
+ : public PerIsolateAssertScope<type, allow> {
public:
explicit PerIsolateAssertScopeDebugOnly(Isolate* isolate)
: PerIsolateAssertScope<type, allow>(isolate) { }

Powered by Google App Engine
This is Rietveld 408576698