Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/assembler.h

Issue 769263002: Add support for enabling DCHECKs in release mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 AssemblerBase* assembler_; 165 AssemblerBase* assembler_;
166 int expected_size_; 166 int expected_size_;
167 int start_offset_; 167 int start_offset_;
168 bool old_value_; 168 bool old_value_;
169 }; 169 };
170 170
171 171
172 // Enable a specified feature within a scope. 172 // Enable a specified feature within a scope.
173 class CpuFeatureScope BASE_EMBEDDED { 173 class CpuFeatureScope BASE_EMBEDDED {
174 public: 174 public:
175 #ifdef DEBUG 175 #if DCHECK_IS_ON
176 CpuFeatureScope(AssemblerBase* assembler, CpuFeature f); 176 CpuFeatureScope(AssemblerBase* assembler, CpuFeature f);
177 ~CpuFeatureScope(); 177 ~CpuFeatureScope();
178 178
179 private: 179 private:
180 AssemblerBase* assembler_; 180 AssemblerBase* assembler_;
181 uint64_t old_enabled_; 181 uint64_t old_enabled_;
182 #else 182 #else
183 CpuFeatureScope(AssemblerBase* assembler, CpuFeature f) {} 183 CpuFeatureScope(AssemblerBase* assembler, CpuFeature f) {}
184 #endif 184 #endif
185 }; 185 };
(...skipping 403 matching lines...) Expand 10 before | Expand all | Expand 10 after
589 void PatchCodeWithCall(Address target, int guard_bytes); 589 void PatchCodeWithCall(Address target, int guard_bytes);
590 590
591 // Check whether this return sequence has been patched 591 // Check whether this return sequence has been patched
592 // with a call to the debugger. 592 // with a call to the debugger.
593 INLINE(bool IsPatchedReturnSequence()); 593 INLINE(bool IsPatchedReturnSequence());
594 594
595 // Check whether this debug break slot has been patched with a call to the 595 // Check whether this debug break slot has been patched with a call to the
596 // debugger. 596 // debugger.
597 INLINE(bool IsPatchedDebugBreakSlotSequence()); 597 INLINE(bool IsPatchedDebugBreakSlotSequence());
598 598
599 #ifdef DEBUG 599 #if DCHECK_IS_ON
600 // Check whether the given code contains relocation information that 600 // Check whether the given code contains relocation information that
601 // either is position-relative or movable by the garbage collector. 601 // either is position-relative or movable by the garbage collector.
602 static bool RequiresRelocation(const CodeDesc& desc); 602 static bool RequiresRelocation(const CodeDesc& desc);
603 #endif 603 #endif
604 604
605 #ifdef ENABLE_DISASSEMBLER 605 #ifdef ENABLE_DISASSEMBLER
606 // Printing 606 // Printing
607 static const char* RelocModeName(Mode rmode); 607 static const char* RelocModeName(Mode rmode);
608 void Print(Isolate* isolate, std::ostream& os); // NOLINT 608 void Print(Isolate* isolate, std::ostream& os); // NOLINT
609 #endif // ENABLE_DISASSEMBLER 609 #endif // ENABLE_DISASSEMBLER
(...skipping 520 matching lines...) Expand 10 before | Expand all | Expand 10 after
1130 NullCallWrapper() { } 1130 NullCallWrapper() { }
1131 virtual ~NullCallWrapper() { } 1131 virtual ~NullCallWrapper() { }
1132 virtual void BeforeCall(int call_size) const { } 1132 virtual void BeforeCall(int call_size) const { }
1133 virtual void AfterCall() const { } 1133 virtual void AfterCall() const { }
1134 }; 1134 };
1135 1135
1136 1136
1137 } } // namespace v8::internal 1137 } } // namespace v8::internal
1138 1138
1139 #endif // V8_ASSEMBLER_H_ 1139 #endif // V8_ASSEMBLER_H_
OLDNEW
« no previous file with comments | « src/arm64/codegen-arm64.cc ('k') | src/assembler.cc » ('j') | src/assembler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698