Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 769253002: Trace how long it takes to compute the weak closure during mark-compact (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Trace how long it takes to compute the weak closure during mark-compact BUG=none R=hpayer@chromium.org LOG=n

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -23 lines) Patch
M src/heap/gc-tracer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/gc-tracer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 1 chunk +27 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
6 years ago (2014-12-02 13:35:27 UTC) #1
Hannes Payer (out of office)
https://codereview.chromium.org/769253002/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/769253002/diff/1/src/heap/mark-compact.cc#newcode2225 src/heap/mark-compact.cc:2225: ProcessTopOptimizedFrame(&root_visitor); I guess you want to start measuring time ...
6 years ago (2014-12-02 14:22:09 UTC) #2
jochen (gone - plz use gerrit)
done, ptal
6 years ago (2014-12-02 14:24:21 UTC) #3
Hannes Payer (out of office)
lgtm
6 years ago (2014-12-02 14:27:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/769253002/20001
6 years ago (2014-12-02 14:27:46 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-02 15:09:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698