gin/isolate_holder.cc - Issue 76923003: First cut at gin::Bind() - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(111)

My Issues | Starred Open | Closed | All

Unified Diff: gin/isolate_holder.cc

Issue 76923003: First cut at gin::Bind() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« gin/function_template.h ('K') | « gin/gin.gyp ('k') | gin/test/gtest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gin/isolate_holder.cc

diff --git a/gin/isolate_holder.cc b/gin/isolate_holder.cc

index 3c2bf9ab20dffa3061bda65d96e85b64225f9780..9e3109d1429a4c7e2ce7f675f1fe17cd99cfd439 100644

--- a/gin/isolate_holder.cc

+++ b/gin/isolate_holder.cc

@@ -11,6 +11,7 @@

#include "base/rand_util.h"

#include "base/sys_info.h"

#include "gin/array_buffer.h"

+#include "gin/function_template.h"

#include "gin/per_isolate_data.h"

namespace gin {

@@ -52,6 +53,7 @@ IsolateHolder::IsolateHolder()

v8::Isolate::Scope isolate_scope(isolate_);

v8::HandleScope handle_scope(isolate_);

isolate_data_.reset(new PerIsolateData(isolate_));

+ CallbackHolderBase::EnsureRegistered(isolate_data_.get());

}

IsolateHolder::IsolateHolder(v8::Isolate* isolate)

« gin/function_template.h ('K') | « gin/gin.gyp ('k') | gin/test/gtest.cc » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698