Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 769223002: Revert of Switch Windows over to BoringSSL from NSS. (Closed)

Created:
6 years ago by markusheintz_
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Switch Windows over to BoringSSL from NSS. (patchset #2 id:20001 of https://codereview.chromium.org/765603002/) Reason for revert: breaks gn build http://build.chromium.org/p/chromium.win/buildstatus?builder=Win8%20GN&number=1126 Original issue's description: > Switch Windows over to BoringSSL from NSS. > > This is a much much larger change than the diff suggests. If it > breaks something, please revert first and ask questions later. > > BUG=338884 > > Committed: https://crrev.com/deaca2e618f14a475045cefcbe03d18eb79aaff7 > Cr-Commit-Position: refs/heads/master@{#306358} TBR=rsleevi@chromium.org,brettw@chromium.org,davidben@chromium.org NOTREECHECKS=true NOTRY=true BUG=338884 Committed: https://crrev.com/211c6e459c4b3cad323aed8a39911eae3e777e63 Cr-Commit-Position: refs/heads/master@{#306370}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M build/config/crypto.gni View 1 chunk +3 lines, -4 lines 0 comments Download
M net/ssl/openssl_platform_key_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
markusheintz_
Created Revert of Switch Windows over to BoringSSL from NSS.
6 years ago (2014-12-02 12:12:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/769223002/1
6 years ago (2014-12-02 12:13:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-02 12:14:06 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-02 12:15:28 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/211c6e459c4b3cad323aed8a39911eae3e777e63
Cr-Commit-Position: refs/heads/master@{#306370}

Powered by Google App Engine
This is Rietveld 408576698