Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 769173002: Move native_viewport and gles2 service impls to //services (Closed)

Created:
6 years ago by jamesr
Modified:
6 years ago
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Move native_viewport and gles2 service impls to //services R=ben@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c9b163e587844fa5c25589116d016b6004ac66a5

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -2642 lines) Patch
M mojo/gles2/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/gles2/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/BUILD.gn View 1 2 chunks +0 lines, -5 lines 0 comments Download
D mojo/services/gles2/BUILD.gn View 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/services/gles2/DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
D mojo/services/gles2/command_buffer_driver.h View 1 chunk +0 lines, -106 lines 0 comments Download
D mojo/services/gles2/command_buffer_driver.cc View 1 chunk +0 lines, -242 lines 0 comments Download
D mojo/services/gles2/command_buffer_impl.h View 1 chunk +0 lines, -70 lines 0 comments Download
D mojo/services/gles2/command_buffer_impl.cc View 1 chunk +0 lines, -160 lines 0 comments Download
D mojo/services/gles2/command_buffer_type_conversions.h View 1 chunk +0 lines, -67 lines 0 comments Download
D mojo/services/gles2/command_buffer_type_conversions.cc View 1 chunk +0 lines, -170 lines 0 comments Download
D mojo/services/gles2/gpu_impl.h View 1 chunk +0 lines, -81 lines 0 comments Download
D mojo/services/gles2/gpu_impl.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D mojo/services/gles2/mojo_buffer_backing.h View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/services/gles2/mojo_buffer_backing.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D mojo/services/native_viewport/BUILD.gn View 1 chunk +0 lines, -108 lines 0 comments Download
D mojo/services/native_viewport/DEPS View 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/services/native_viewport/android/src/org/chromium/mojo/PlatformViewportAndroid.java View 1 chunk +0 lines, -91 lines 0 comments Download
D mojo/services/native_viewport/main.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D mojo/services/native_viewport/native_viewport_impl.h View 1 chunk +0 lines, -69 lines 0 comments Download
D mojo/services/native_viewport/native_viewport_impl.cc View 1 chunk +0 lines, -168 lines 0 comments Download
D mojo/services/native_viewport/platform_viewport.h View 1 chunk +0 lines, -53 lines 0 comments Download
D mojo/services/native_viewport/platform_viewport_android.h View 1 chunk +0 lines, -66 lines 0 comments Download
D mojo/services/native_viewport/platform_viewport_android.cc View 1 chunk +0 lines, -156 lines 0 comments Download
D mojo/services/native_viewport/platform_viewport_headless.h View 1 chunk +0 lines, -36 lines 0 comments Download
D mojo/services/native_viewport/platform_viewport_headless.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/services/native_viewport/platform_viewport_mac.mm View 1 chunk +0 lines, -72 lines 0 comments Download
D mojo/services/native_viewport/platform_viewport_ozone.cc View 1 chunk +0 lines, -95 lines 0 comments Download
D mojo/services/native_viewport/platform_viewport_stub.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D mojo/services/native_viewport/platform_viewport_win.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D mojo/services/native_viewport/platform_viewport_x11.cc View 1 chunk +0 lines, -130 lines 0 comments Download
D mojo/services/native_viewport/viewport_surface.h View 1 chunk +0 lines, -58 lines 0 comments Download
D mojo/services/native_viewport/viewport_surface.cc View 1 chunk +0 lines, -118 lines 0 comments Download
M mojo/shell/BUILD.gn View 1 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/shell/android/library_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/context.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/BUILD.gn View 1 2 chunks +5 lines, -0 lines 0 comments Download
A + services/gles2/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/gles2/command_buffer_driver.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/gles2/command_buffer_driver.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/gles2/command_buffer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/gles2/command_buffer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/gles2/command_buffer_type_conversions.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/gles2/command_buffer_type_conversions.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/gles2/gpu_impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
A + services/gles2/gpu_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + services/gles2/mojo_buffer_backing.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/gles2/mojo_buffer_backing.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/native_viewport/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A + services/native_viewport/android/src/org/chromium/mojo/PlatformViewportAndroid.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/native_viewport/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/native_viewport/native_viewport_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + services/native_viewport/native_viewport_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/native_viewport/platform_viewport.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/native_viewport/platform_viewport_android.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + services/native_viewport/platform_viewport_android.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/native_viewport/platform_viewport_headless.h View 2 chunks +6 lines, -1 line 0 comments Download
A + services/native_viewport/platform_viewport_headless.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/native_viewport/platform_viewport_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
A + services/native_viewport/platform_viewport_ozone.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/native_viewport/platform_viewport_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/native_viewport/platform_viewport_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/native_viewport/platform_viewport_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/native_viewport/viewport_surface.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/native_viewport/viewport_surface.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
jamesr
6 years ago (2014-12-02 02:22:17 UTC) #1
Ben Goodger (Google)
lgtm
6 years ago (2014-12-02 23:26:29 UTC) #4
jamesr
6 years ago (2014-12-03 21:31:37 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
c9b163e587844fa5c25589116d016b6004ac66a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698