Managed bookmarks for supervised users

chrome/browser/bookmarks/chrome_bookmark_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BOOKMARKS_CHROME_BOOKMARK_CLIENT_H_
 #define CHROME_BROWSER_BOOKMARKS_CHROME_BOOKMARK_CLIENT_H_
 
 #include <set>
 #include <vector>
 
@@ skipping 16 matching lines @@
   explicit ChromeBookmarkClient(Profile* profile);
   ~ChromeBookmarkClient() override;
 
   void Init(BookmarkModel* model);
 
   // KeyedService:
   void Shutdown() override;
 
   // Returns the managed_node.
   const BookmarkNode* managed_node() { return managed_node_; }
+  // Returns the supervised_node.

[Pam (message me for reviews), 2015/01/14 14:03:37]

This comment (and the managed_node() one above) is really pointless.

[Marc Treib, 2015/01/14 16:40:50]

I guess somebody wanted every public method to have a comment. But agreed; I've
removed the comments.

+  const BookmarkNode* supervised_node() { return supervised_node_; }
 
   // Returns true if the given node belongs to the managed bookmarks tree.
   bool IsDescendantOfManagedNode(const BookmarkNode* node);
-
   // Returns true if there is at least one managed node in the |list|.
   bool HasDescendantsOfManagedNode(
       const std::vector<const BookmarkNode*>& list);
 
+  // Returns true if the given node belongs to the supervised bookmarks tree.
+  bool IsDescendantOfSupervisedNode(const BookmarkNode* node);
+  // Returns true if there is at least one supervised node in the |list|.
+  bool HasDescendantsOfSupervisedNode(
+      const std::vector<const BookmarkNode*>& list);
+
+  // Returns true if the given node belongs to either the managed or the
+  // supervised bookmarks tree.
+  bool IsDescendantOfManagedOrSupervisedNode(const BookmarkNode* node);
+  // Returns true if there is at least one managed or supervised node in the
+  // |list|.
+  bool HasDescendantsOfManagedOrSupervisedNode(
+      const std::vector<const BookmarkNode*>& list);
+
   // bookmarks::BookmarkClient:
   bool PreferTouchIcon() override;
   base::CancelableTaskTracker::TaskId GetFaviconImageForPageURL(
       const GURL& page_url,
       favicon_base::IconType type,
       const favicon_base::FaviconImageCallback& callback,
       base::CancelableTaskTracker* tracker) override;
   bool SupportsTypedCountForNodes() override;
   void GetTypedCountForNodes(
       const NodeSet& nodes,
@@ skipping 17 matching lines @@
                            const BookmarkNode* node,
                            const std::set<GURL>& removed_urls) override;
   void BookmarkAllUserNodesRemoved(BookmarkModel* model,
                                    const std::set<GURL>& removed_urls) override;
   void BookmarkModelLoaded(BookmarkModel* model, bool ids_reassigned) override;
 
   // Helper for GetLoadExtraNodesCallback().
   static bookmarks::BookmarkPermanentNodeList LoadExtraNodes(
       scoped_ptr<BookmarkPermanentNode> managed_node,
       scoped_ptr<base::ListValue> initial_managed_bookmarks,
+      scoped_ptr<BookmarkPermanentNode> supervised_node,
+      scoped_ptr<base::ListValue> initial_supervised_bookmarks,
       int64* next_node_id);
 
   // Returns the management domain that configured the managed bookmarks,
   // or an empty string.
   std::string GetManagedBookmarksDomain();
 
   Profile* profile_;
 
   // HistoryService associated to the Profile. Due to circular dependency, this
   // cannot be passed to the constructor, nor lazily fetched. Instead the value
   // is initialized from HistoryServiceFactory.
   HistoryService* history_service_;
 
   scoped_ptr<base::CallbackList<void(const std::set<GURL>&)>::Subscription>
       favicon_changed_subscription_;
 
   // Pointer to the BookmarkModel. Will be non-NULL from the call to Init to
   // the call to Shutdown. Must be valid for the whole interval.
   BookmarkModel* model_;
 
   scoped_ptr<policy::ManagedBookmarksTracker> managed_bookmarks_tracker_;
   BookmarkPermanentNode* managed_node_;

[Pam (message me for reviews), 2015/01/14 14:03:37]

Somewhere in this file, maybe as comments for managed_node_ and
supervised_node_, it needs a better description of the difference between
"managed" and "supervised" bookmarks.

[Marc Treib, 2015/01/14 16:40:50]

Done.

 
+  scoped_ptr<policy::ManagedBookmarksTracker> supervised_bookmarks_tracker_;
+  BookmarkPermanentNode* supervised_node_;
+
   DISALLOW_COPY_AND_ASSIGN(ChromeBookmarkClient);
 };
 
 #endif  // CHROME_BROWSER_BOOKMARKS_CHROME_BOOKMARK_CLIENT_H_