Managed bookmarks for supervised users

components/policy/core/browser/managed_bookmarks_tracker.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_POLICY_CORE_BROWSER_MANAGED_BOOKMARKS_TRACKER_H_
 #define COMPONENTS_POLICY_CORE_BROWSER_MANAGED_BOOKMARKS_TRACKER_H_
 
 #include "base/callback_forward.h"
 #include "base/macros.h"
 #include "base/prefs/pref_change_registrar.h"
 #include "base/strings/string16.h"
 #include "components/policy/policy_export.h"
 
 class BookmarkNode;
 class BookmarkPermanentNode;
 class GURL;
 class PrefService;
 
 namespace base {
 class ListValue;
 }
 
 namespace bookmarks {
 class BookmarkModel;
 }
 
 namespace policy {
 
-// Tracks the Managed Bookmarks policy value and makes the managed_node() in
-// the BookmarkModel follow the policy-defined bookmark tree.
+// Tracks either the Managed Bookmarks pref (set by policy) or the Supervised
+// Bookmarks pref (set for a supervised user by their custodian) and makes the
+// managed_node()/supervised_node() in the BookmarkModel follow the
+// policy/custodian-defined bookmark tree.
 class POLICY_EXPORT ManagedBookmarksTracker {
  public:
   typedef base::Callback<std::string()> GetManagementDomainCallback;
 
   // Shared constants used in the policy configuration.
   static const char kName[];
   static const char kUrl[];
   static const char kChildren[];
 
+  // If |is_supervised| is true, this will track supervised bookmarks rather
+  // than managed bookmarks.
   ManagedBookmarksTracker(bookmarks::BookmarkModel* model,
                           PrefService* prefs,
+                          bool is_supervised,
                           const GetManagementDomainCallback& callback);
   ~ManagedBookmarksTracker();
 
   // Returns the initial list of managed bookmarks, which can be passed to
   // LoadInitial() to do the initial load.
   scoped_ptr<base::ListValue> GetInitialManagedBookmarks();
 
-  // Loads the initial managed bookmarks in |list| into |folder|. New nodes
-  // will be assigned IDs starting at |next_node_id|.
+  // Loads the initial managed/supervised bookmarks in |list| into |folder|.
+  // New nodes will be assigned IDs starting at |next_node_id|.
   // Returns the next node ID to use.
   static int64 LoadInitial(BookmarkNode* folder,
                            const base::ListValue* list,
                            int64 next_node_id);
 
-  // Starts tracking the policy for updates to the managed bookmarks. Should
-  // be called after loading the initial bookmarks.
+  // Starts tracking the policy for updates to the managed/supervised bookmarks.

[bartfab (slow), 2015/01/26 15:40:14]

Nit: s/policy/pref/

[Marc Treib, 2015/01/26 16:16:47]

Done.

+  // Should be called after loading the initial bookmarks.
   void Init(BookmarkPermanentNode* managed_node);
 
+  bool is_supervised() const { return is_supervised_; }
+
+  // Public for testing.
+  static const char* GetPrefName(bool is_supervised);
+
  private:
+  const char* GetPrefName() const;
+  base::string16 GetBookmarksFolderTitle() const;

[bartfab (slow), 2015/01/26 15:40:14]

Nit: #include "base/strings/string16.h"

[Marc Treib, 2015/01/26 16:16:47]

That's already there.

+
   void ReloadManagedBookmarks();
+
   void UpdateBookmarks(const BookmarkNode* folder, const base::ListValue* list);
   static bool LoadBookmark(const base::ListValue* list,
                            size_t index,
                            base::string16* title,
                            GURL* url,
                            const base::ListValue** children);
 
   bookmarks::BookmarkModel* model_;
+  bool is_supervised_;

[bartfab (slow), 2015/01/26 15:40:14]

Nit: const.

[Marc Treib, 2015/01/26 16:16:47]

Done.

   BookmarkPermanentNode* managed_node_;
   PrefService* prefs_;
   PrefChangeRegistrar registrar_;
   GetManagementDomainCallback get_management_domain_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagedBookmarksTracker);
 };
 
 }  // namespace policy
 
 #endif  // COMPONENTS_POLICY_CORE_BROWSER_MANAGED_BOOKMARKS_TRACKER_H_