Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc

Issue 769153007: Managed bookmarks for supervised users (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: string change Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h" 5 #include "chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h"
6 6
7 #include <math.h> // For floor() 7 #include <math.h> // For floor()
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 } 68 }
69 } 69 }
70 70
71 bookmark_tree_node->title = base::UTF16ToUTF8(node->GetTitle()); 71 bookmark_tree_node->title = base::UTF16ToUTF8(node->GetTitle());
72 if (!node->date_added().is_null()) { 72 if (!node->date_added().is_null()) {
73 // Javascript Date wants milliseconds since the epoch, ToDoubleT is seconds. 73 // Javascript Date wants milliseconds since the epoch, ToDoubleT is seconds.
74 bookmark_tree_node->date_added.reset( 74 bookmark_tree_node->date_added.reset(
75 new double(floor(node->date_added().ToDoubleT() * 1000))); 75 new double(floor(node->date_added().ToDoubleT() * 1000)));
76 } 76 }
77 77
78 if (client->IsDescendantOfManagedNode(node)) 78 if (client->IsDescendantOfManagedOrSupervisedNode(node))
79 bookmark_tree_node->unmodifiable = BookmarkTreeNode::UNMODIFIABLE_MANAGED; 79 bookmark_tree_node->unmodifiable = BookmarkTreeNode::UNMODIFIABLE_MANAGED;
80 80
81 if (recurse && node->is_folder()) { 81 if (recurse && node->is_folder()) {
82 std::vector<linked_ptr<BookmarkTreeNode> > children; 82 std::vector<linked_ptr<BookmarkTreeNode> > children;
83 for (int i = 0; i < node->child_count(); ++i) { 83 for (int i = 0; i < node->child_count(); ++i) {
84 const BookmarkNode* child = node->GetChild(i); 84 const BookmarkNode* child = node->GetChild(i);
85 if (child->IsVisible() && (!only_folders || child->is_folder())) { 85 if (child->IsVisible() && (!only_folders || child->is_folder())) {
86 linked_ptr<BookmarkTreeNode> child_node( 86 linked_ptr<BookmarkTreeNode> child_node(
87 GetBookmarkTreeNode(client, child, true, only_folders)); 87 GetBookmarkTreeNode(client, child, true, only_folders));
88 children.push_back(child_node); 88 children.push_back(child_node);
(...skipping 26 matching lines...) Expand all
115 std::string* error) { 115 std::string* error) {
116 const BookmarkNode* node = bookmarks::GetBookmarkNodeByID(model, id); 116 const BookmarkNode* node = bookmarks::GetBookmarkNodeByID(model, id);
117 if (!node) { 117 if (!node) {
118 *error = keys::kNoNodeError; 118 *error = keys::kNoNodeError;
119 return false; 119 return false;
120 } 120 }
121 if (model->is_permanent_node(node)) { 121 if (model->is_permanent_node(node)) {
122 *error = keys::kModifySpecialError; 122 *error = keys::kModifySpecialError;
123 return false; 123 return false;
124 } 124 }
125 if (client->IsDescendantOfManagedNode(node)) { 125 if (client->IsDescendantOfManagedOrSupervisedNode(node)) {
126 *error = keys::kModifyManagedError; 126 *error = keys::kModifyManagedError;
127 return false; 127 return false;
128 } 128 }
129 if (node->is_folder() && !node->empty() && !recursive) { 129 if (node->is_folder() && !node->empty() && !recursive) {
130 *error = keys::kFolderNotEmptyError; 130 *error = keys::kFolderNotEmptyError;
131 return false; 131 return false;
132 } 132 }
133 133
134 const BookmarkNode* parent = node->parent(); 134 const BookmarkNode* parent = node->parent();
135 model->Remove(parent, parent->GetIndexOf(node)); 135 model->Remove(parent, parent->GetIndexOf(node));
(...skipping 17 matching lines...) Expand all
153 153
154 if (node.is_folder()) { 154 if (node.is_folder()) {
155 for (int i = 0; i < node.child_count(); ++i) { 155 for (int i = 0; i < node.child_count(); ++i) {
156 GetMetaInfo(*(node.GetChild(i)), id_to_meta_info_map); 156 GetMetaInfo(*(node.GetChild(i)), id_to_meta_info_map);
157 } 157 }
158 } 158 }
159 } 159 }
160 160
161 } // namespace bookmark_api_helpers 161 } // namespace bookmark_api_helpers
162 } // namespace extensions 162 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698