Add matrix operations to C canvas API

Add matrix operations to C canvas API

R=reed@google.com
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/9503ac7a3cc98327a88eff59c71c451fbdd7e043

[abarth-chromium, 2014-12-01 22:12:31]

abarth@chromium.org changed reviewers:
+ reed@google.com
- reed@chromium.org

[reed1, 2014-12-02 15:52:31]

https://codereview.chromium.org/769123002/diff/1/include/c/sk_canvas.h
File include/c/sk_canvas.h (right):

https://codereview.chromium.org/769123002/diff/1/include/c/sk_canvas.h#newcode29
include/c/sk_canvas.h:29: void sk_canvas_set_matrix(sk_canvas_t*, const
sk_matrix_t*);
We want to deprecate setMatrix and resetMatrix, so lets only expose concat at
the C level.

[abarth-chromium, 2014-12-02 17:23:36]

Done.  PTAL.

[reed1, 2014-12-02 17:41:43]

lgtm w/ suggestion about null-check.

also, feel free to extend tests/CTests.cpp as you see fit.

https://codereview.chromium.org/769123002/diff/20001/src/c/sk_surface.cpp
File src/c/sk_surface.cpp (right):

https://codereview.chromium.org/769123002/diff/20001/src/c/sk_surface.cpp#new...
src/c/sk_surface.cpp:334: SkMatrix matrix;
can probably move the null-check to here, rather than in the converter (assuming
we want that and not to just crash/assert).

[abarth-chromium, 2014-12-02 17:43:16]

https://codereview.chromium.org/769123002/diff/20001/src/c/sk_surface.cpp
File src/c/sk_surface.cpp (right):

https://codereview.chromium.org/769123002/diff/20001/src/c/sk_surface.cpp#new...
src/c/sk_surface.cpp:334: SkMatrix matrix;
On 2014/12/02 at 17:41:43, reed1 wrote:
> can probably move the null-check to here, rather than in the converter
(assuming we want that and not to just crash/assert).

IMHO, we should crash/assert.  It seems better for the API to be strict, at
least at the beginning.  We can always loosen these things later, but they're
much harder to tighten.

[abarth-chromium, 2014-12-02 23:36:19]

On 2014/12/02 at 17:41:43, reed wrote:
> also, feel free to extend tests/CTests.cpp as you see fit.

I tried adding a test, but we're missing the sk_matrix_* functions.  I'll add
them in the next CL and add a test.

> https://codereview.chromium.org/769123002/diff/20001/src/c/sk_surface.cpp
> File src/c/sk_surface.cpp (right):
> 
>
https://codereview.chromium.org/769123002/diff/20001/src/c/sk_surface.cpp#new...
> src/c/sk_surface.cpp:334: SkMatrix matrix;
> can probably move the null-check to here, rather than in the converter
(assuming we want that and not to just crash/assert).

Done.

[abarth-chromium, 2014-12-02 23:36:24]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-12-02 23:37:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/769123002/40001

[commit-bot: I haz the power, 2014-12-02 23:47:38]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/9503ac7a3cc98327a88eff59c71c451fbdd7e043