test/js-perf-test/Templates/Templates.json - Issue 769113002: Perf tests for Template Literals

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/js-perf-test/Templates/Templates.json

Issue 769113002: Perf tests for Template Literals (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 {

	2 "name": "JSTests/Templates",

	3 "path": ["."],

	4 "main": "run.js",

	5 "flags": ["--harmony-templates"],

	6 "run_count": 5,
	arv (Not doing code reviews) 2014/12/01 20:04:07 Try increasing this if the test is really fast Try increasing this if the test is really fast caitp (gmail) 2014/12/01 20:11:22 I don't think that solves the problem --- each ste Show quoted text On 2014/12/01 20:04:07, arv wrote: > Try increasing this if the test is really fast I don't think that solves the problem --- each step takes 1000ms to get through (we elapse like 30,000+ runs in each step) but the reporting for those iterations never happens. It looked to me like if it doesn't get through an expected iteration count, it will report results, but if it does, it won't. I feel like it's a bug in the benchmark itself, but I'm not positive. (I've tried this with 100 steps instead of 5, same issue --- no results output).
	7 "units": "score",

	8 "results_regexp": "^%s\\-Templates\$Score\$: (.+)$",

	9 "total": true,

	10 "tests": [

	11 {"name": "TemplateLiterals"}

	12 ]

	13 }

OLD	NEW