chrome/browser/chrome_content_browser_client.cc - Issue 769103002: Refactor ProtectedMediaIdentifierPermissionContext to derive from PermissionContextBase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 769103002: Refactor ProtectedMediaIdentifierPermissionContext to derive from PermissionContextBase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: apply comments, fix compile Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/content_settings/permission_context_base.h » ('j') | chrome/browser/content_settings/permission_context_uma_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index 4f58d2fba0344ebf080b42057b37b3dc1c8a5d6a..3058b8a9b5c74d4c5c97600535b7965b46ae8786 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -1953,8 +1953,11 @@ void ChromeContentBrowserClient::RequestPermission(

case content::PERMISSION_PROTECTED_MEDIA:

#if defined(OS_ANDROID)

ProtectedMediaIdentifierPermissionContextFactory::GetForProfile(profile)

- ->RequestProtectedMediaIdentifierPermission(

- web_contents, requesting_frame, result_callback);

+ ->RequestPermission(web_contents,

+ request_id,

+ requesting_frame.GetOrigin(),

+ user_gesture,

+ result_callback);

#else

NOTIMPLEMENTED();

#endif

@@ -2007,8 +2010,7 @@ void ChromeContentBrowserClient::CancelPermissionRequest(

case content::PERMISSION_PROTECTED_MEDIA:

#if defined(OS_ANDROID)

ProtectedMediaIdentifierPermissionContextFactory::GetForProfile(profile)

- ->CancelProtectedMediaIdentifierPermissionRequests(

- render_process_id, render_view_id, requesting_frame);

+ ->CancelPermissionRequest(web_contents, request_id);

#else

NOTIMPLEMENTED();

#endif

« no previous file with comments | « no previous file | chrome/browser/content_settings/permission_context_base.h » ('j') | chrome/browser/content_settings/permission_context_uma_util.cc » ('J')