Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 769083003: multipage_pdf_profiler, gmtoskp (Closed)

Created:
6 years ago by hal.canary
Modified:
6 years ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -1 line) Patch
A experimental/tools/gmtoskp.cpp View 1 chunk +78 lines, -0 lines 0 comments Download
A experimental/tools/multipage_pdf_profiler.cpp View 1 chunk +138 lines, -0 lines 0 comments Download
A experimental/tools/multipage_pdf_profiler.sh View 1 chunk +18 lines, -0 lines 1 comment Download
M gyp/experimental.gyp View 1 chunk +36 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
hal.canary
These two executables are only ever meant to live in experimental; I've been using them ...
6 years ago (2014-12-01 19:22:00 UTC) #2
djsollen
https://codereview.chromium.org/769083003/diff/1/experimental/tools/multipage_pdf_profiler.sh File experimental/tools/multipage_pdf_profiler.sh (right): https://codereview.chromium.org/769083003/diff/1/experimental/tools/multipage_pdf_profiler.sh#newcode12 experimental/tools/multipage_pdf_profiler.sh:12: for skp in "$SKP_DIRECTORY"/*.skp; do why not do this ...
6 years ago (2014-12-01 19:44:49 UTC) #3
djsollen
lgtm
6 years ago (2014-12-01 19:49:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/769083003/1
6 years ago (2014-12-01 20:11:58 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-01 20:21:28 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/742cacdd20034c70f826b60eb416f7cc0a81d587

Powered by Google App Engine
This is Rietveld 408576698